Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54929 closed defect (bug) (fixed)

Twenty Twenty-Two: Pricing Table pattern header levels should be consistent

Reported by: kjellr's profile kjellr Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

The heading levels in the "Pricing Table" pattern bundled with Twenty Twenty-Two are not consistent.

"Pigeon" is a H3, but the other two are H2s. These should all be H3s.

---

Originally reported by @bobbingwide over in GitHub:
https://github.com/WordPress/twentytwentytwo/issues/341

Attachments (1)

150486699-68fc52eb-19cc-4cbf-9657-f6015159929d.png (101.2 KB) - added by kjellr 2 years ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in PR #2229 on WordPress/wordpress-develop by jffng.


2 years ago
#1

  • Keywords has-patch added; needs-patch removed

Fixes https://core.trac.wordpress.org/ticket/54929 and https://core.trac.wordpress.org/ticket/54928.

To test, check insert the Pricing Table pattern and verify the Heading levels are correct:

https://i0.wp.com/user-images.githubusercontent.com/5375500/151209104-00fdb1fe-81e2-4335-b5a5-13b6458c7869.png

Also visit the 404 template and verify the search block renders correctly.

audrasjb commented on PR #2229:


2 years ago
#2

I removed the changes related to hidden-404 pattern since this has already been fixed earlier :)

#3 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 52681:

Twenty Twenty-Two: Fix headings consistency in Pricing table pattern.

This change fixes a consistency issue where "Pigeon" was a h3, while "Sparrow" and "Falcon" were h2. Let's treat these birds equally 🐦

Props kjellr, jffng.
Fixes #54929.

#5 @audrasjb
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.9 backport.

#6 @SergeyBiryukov
2 years ago

  • Summary changed from [Twenty Twenty-Two] Pricing Table pattern header levels should be consistent to Twenty Twenty-Two: Pricing Table pattern header levels should be consistent

#7 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52711:

Twenty Twenty-Two: Fix headings consistency in Pricing table pattern.

This change fixes a consistency issue where "Pigeon" was a h3, while "Sparrow" and "Falcon" were h2. Let's treat these birds equally 🐦

Props kjellr, jffng, audrasjb.
Merges [52681] to the 5.9 branch.
Fixes #54929.

Note: See TracTickets for help on using tickets.