Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #54937


Ignore:
Timestamp:
01/26/2022 10:47:38 PM (2 years ago)
Author:
SergeyBiryukov
Comment:

Hi there, welcome to WordPress Trac! Thanks for the ticket and the patch.

The code in question was added in [46202] / #14459, changing the version accordingly.

Moving to 6.0 for investigation.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54937

    • Property Version changed from 5.9 to 5.3
    • Property Milestone changed from Awaiting Review to 6.0
  • Ticket #54937 – Description

    initial v1  
    1010On wp-includes/class-wp-image-editor.php, the function flip() is being called with swapped parameters.
    1111
    12 I presume there was probably some confusion around the meaning of $horz and $vert params. Rather than flipping the image horizontally and vertically, respectively, they actually flip the image along the horizontal and vertical axis, respectively, which is the complete opposite behavior. This subject has already been discussed on:
    13 
    14 https://core.trac.wordpress.org/ticket/23775
     12I presume there was probably some confusion around the meaning of $horz and $vert params. Rather than flipping the image horizontally and vertically, respectively, they actually flip the image along the horizontal and vertical axis, respectively, which is the complete opposite behavior. This subject has already been discussed on: #23775.
    1513
    1614**Proposed solution**