Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 18 months ago

#54945 closed defect (bug) (fixed)

”Edit media”-links opening in new tabs with target="_blank"

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch commit dev-reviewed
Focuses: accessibility, administration Cc:


The edit links should not open in new tabs. PR is on its way.

Could not find the changeset that introduced it, it is there in

Change History (8)

This ticket was mentioned in PR #2231 on WordPress/wordpress-develop by kebbet.

2 years ago

  • Keywords has-patch added; needs-patch removed

#2 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.0
  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for spotting this!
Moving for 6.0 consideration 👍

#3 @SergeyBiryukov
2 years ago

  • Version changed from 3.7 to 3.5

Introduced in [22755] / #22083, setting the version accordingly.

Related: #23432.

#4 @audrasjb
2 years ago

  • Keywords commit added
  • Status changed from reviewing to accepted

The patch looks good to me. Self-assigning for commit consideration.

#5 @audrasjb
2 years ago

  • Keywords dev-reviewed added

I was a bit afraid this change could break uploads of multiple files, but I tested the PR and it appears that even if the Edit link opens in the same tab, the rest of the media are successfully uploaded. Asynchronous uploads FTW 😎

We're good to go.

#6 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52646:

Media: Remove target blank attribute from media uploader edit links.

This change removes a dispensable target blank attribute from Edit links displayed in the asynchronous file uploader.

Follow-up to [22755].

Props kebbet, SergeyBiryukov.
Fixes #54945.
See #23432.

#8 @desrosj
18 months ago

#40125 was marked as a duplicate.

Note: See TracTickets for help on using tickets.