Custom fields Issue

[gadhiyaravi]

Custom fields glitch: when i am trying to add custom field, it is not showing correctly, Image link:
​https://ibb.co/Zc1VGx7

[gadhiyaravi]

Image

[Boniu91]

Thank you for creating the ticket! I'm able to reproduce.

Steps to test

1. Use WordPress 5.9
2. Add new page in the Settings - Preferences - Panels enable Custom Fields
3. Add custom field and save it
4. See the success message not being styled correctly

[ravipatel]

Patch for when added a meta box and show ajax layout top and fixed with this patch

[ravipatel]

After added this css, field structure display like this.

[joedolson]

There's a related issue found when adding a new category term in the editor. This could be related to #42937.

[joedolson]

Screenshot with blank success notification after inserting new category from block editor.

[sabernhardt]

I did not think this was related to r52170, but removing successmsg += response.data; confirmed it. The table row output is in the response.data for an Ajax call in the custom fields section.

One way to avoid the custom fields message is checking whether the admin screen is editing the Taxonomy terms before adding response.data to the message:

	if ( jQuery( 'body' ).hasClass( 'edit-tags-php' ) ) {
		successmsg += response.data;
	}

That option is not ideal, especially if WordPress adds success messages elsewhere, though it might be good enough for now.

To avoid empty messages, the err.length check's else statement needs to check the successmsg length:

	} else if ( successmsg.length ) {

[SergeyBiryukov]

#55047 was marked as a duplicate.

[audrasjb]

As discussed during today's bug scrub, there is two steps in this ticket:

1. Remove completely the success message for now, and ship it in 5.9.1, as a bug fix.
2. Open a new ticket to consider adding success messages the good way, as an enhancement.

[sabernhardt]

keeping success message on Taxonomy screen but removing extra code from editor screen (custom fields and categories)

[joedolson]

Tested: unwanted empty notices not showing, category success message is showing, as expected.

[joedolson]

In 52672:

Comments: Only render term update notices on term screens.

Prevent blank notices from appearing when adding custom fields or terms in the post editor.

Props gadhiyaravi, Boniu91, ravipatel, sabernhardt.
Fixes #54955. See #42937.

[SergeyBiryukov]

Reopening for backporting to the 5.9 branch.

[SergeyBiryukov]

Replying to audrasjb:

Open a new ticket to consider adding success messages the good way, as an enhancement.

Follow-up: #55078.

[SergeyBiryukov]

When committing a fix for a minor release, please don't forget to also reopen the ticket for backporting to the branch and add the fixed-major keyword. Otherwise, the ticket stays on the milestone for the next minor release, but is not actually fixed there :)

[joedolson]

Thanks for the note @SergeyBiryukov! I didn't know that I needed to do that, so I've added it to my notes.

[peterwilsoncc]

In 52728:

Editor: Only render term update notices on term screens.

Prevent blank notices from appearing when adding custom fields or terms in the post editor.

Props gadhiyaravi, Boniu91, ravipatel, sabernhardt, joedolson.
Fixes #54955. See #42937.

[peterwilsoncc]

In 53123:

Administration: Remove term page check from ajax-response.js.

Replace hard coded check for the term creation page in _enqueues/lib/ajax-response.js with a check for a notification to display in the AJAX response data.

Follow up to [52170], [52672].

Props SergeyBiryukov, ryokuhi, johnregan3, sabernhardt, joedolson.
Fixes #55078.
See #54955.