Make WordPress Core

Opened 2 years ago

Last modified 11 months ago

#54970 reviewing defect (bug)

"Please update WordPress" link on incompatible theme tile on the "Add Themes" view is not clickable

Reported by: tomasza8c's profile tomasza8c Owned by: audrasjb's profile audrasjb
Milestone: Future Release Priority: normal
Severity: normal Version: 5.5
Component: Themes Keywords: has-screenshots has-patch changes-requested
Focuses: ui, css Cc:

Description

Interaction is prevented by the "Details & Preview" overlay. Trying to click the "Please update WordPress" link on the warning ribbon opens the theme preview.

This happened when trying to install Twenty Twenty-Two theme on WordPress 5.8.

It is possible to update WordPress with any other available flow like the "WordPress 5.9 is available! Please update now" message on top of the page.

Attachments (2)

Screenshot 2022-01-28 at 12.55.06.png (259.4 KB) - added by tomasza8c 2 years ago.
a033e7d5ea69b1de59d281eab0ff0a84.gif (2.3 MB) - added by audrasjb 21 months ago.
Testing patch suggested in PR3235

Change History (22)

#1 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Hello and welcome to WordPress Trac @tomasza8c,

Tested on WP 5.8.3 on Mac OSX + Chrome and it works for me: when I click the link, the theme modal opens but I'm also redirected to the upgrade WP screen. See video screenshot: https://i.gyazo.com/54585c2a32b084256152a833625060cc.mp4

Do you have more context to reproduce the issue?

#2 @tomasza8c
2 years ago

Hi @audrasjb, thanks for looking into it.

The "Add theme" view I've mentioned and the "Themes" view you've tested it on seem to have a bit different behaviour on the tiles. If you take a look at the screenshot provided it has a different callout on hover. "Details & Preview" vs "Theme details" on the "Themes" view. On "Add theme" it seems to open Live Preview which redirects to theme preview and redirect to update doesn't happen then.

Version 0, edited 2 years ago by tomasza8c (next)

#3 @audrasjb
2 years ago

  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to 6.0
  • Severity changed from trivial to normal
  • Version 5.8.3 deleted

AH ok got it. So the good way to reproduce the issue is currently:

  • Rollback to a former version of WP, like 5.8.3
  • Make sure you don't have TT2 theme installed or delete it
  • Go to "Add theme" and search for Twenty Twenty-Two
  • The "Please update WordPress" link in the notice is not reachable as it takes you to the customizer preview

Solution:

I think we should simply deactivate the link to the customizer preview for theme we can't install. It should solve the issue.

#4 @audrasjb
2 years ago

  • Milestone changed from 6.0 to Awaiting Review

Taking this out of milestone 6.0 for now.

#5 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.0

Putting this into the milestone again, since I'm working on a patch. It can stays after beta 1 since it is a bugfix.

#6 @costdev
2 years ago

  • Version set to 5.5

#7 @costdev
2 years ago

  • Milestone changed from 6.0 to 6.1

After chatting with @peterwilsoncc, we felt that with no progress as we approach 6.0 RC1 tomorrow, this should be moved to the 6.1 milestone.

#8 @poena
21 months ago

Hi @audrasjb! Do you have any thoughts on how to disable the customizer overlay? It is a JavaScript template, and I was not able to hide the template and display the theme details modal in its place.

#9 @audrasjb
21 months ago

Hey @poena I think I found a workaround.
PR and screenshot incoming.

This ticket was mentioned in PR #3235 on WordPress/wordpress-develop by audrasjb.


21 months ago
#10

  • Keywords has-patch added

@audrasjb
21 months ago

Testing patch suggested in PR3235

#11 @poena
21 months ago

With this PR, is there no way to access any theme information?

That does not feel like a good compromise to me. Currently you can both access theme information, and you have several ways to update WordPress, including clicking through to the Customizer and clicking the update link in the Customizer sidebar.

#12 @audrasjb
21 months ago

  • Keywords changes-requested added

Ah yes. Then we could enable only the preview button. I think it may work.

#13 @audrasjb
20 months ago

  • Milestone changed from 6.1 to 6.2

With WP 6.1 RC 1 scheduled tomorrow (Oct 10, 2022), there is not much time left to address this ticket. Let's move it to the next milestone.

Ps: if you were about to send a patch and if you believe it is realistic to commit it in the next few hours, please feel free to move this ticket back to milestone 6.1.

This ticket was mentioned in Slack in #core by costdev. View the logs.


16 months ago

This ticket was mentioned in Slack in #core by costdev. View the logs.


15 months ago

#16 @costdev
15 months ago

  • Milestone changed from 6.2 to 6.3

This ticket was discussed in the bug scrub and it was agreed to move this ticket to 6.3.

This ticket was mentioned in Slack in #core by chaion07. View the logs.


11 months ago

#18 @chaion07
11 months ago

Thanks @tomasza8c for reporting this. We reviewed this ticket during a recent bug-scrub session. Based on the feedback received we suggest that this PR received an update from JB. Cheers!

Props to @costdev

This ticket was mentioned in Slack in #core by oglekler. View the logs.


11 months ago

#20 @oglekler
11 months ago

  • Milestone changed from 6.3 to Future Release

Due to lack of activity and that patch needs further work, I am moving this ticket into future release.

Note: See TracTickets for help on using tickets.