Opened 3 years ago
Closed 3 years ago
#54977 closed defect (bug) (fixed)
Dashboard welcome banner: fix bug when displayed in certain contexts
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.9.1 | Priority: | normal |
| Severity: | normal | Version: | 5.9 |
| Component: | Administration | Keywords: | has-patch has-testing-info has-screenshots commit fixed-major |
| Focuses: | css, administration | Cc: |
Description
Hi all, I'm reporting a bug that was noticed on the Dashboard where the welcome banner appears to only take up the left side of the screen (rather than the full width of the screen). In this case, the banner is appearing completely to the right of the "Screen options" and "Help" tabs in the upper right corner but those tabs should actually sit above the banner.
This bug was found in Safari and it appears that it could be a conflict with other banners that get added to this area (from jurassic.ninja, Jetpack, etc). But the misaligned visual effect remains even after other banners are closed.
Attachments (3)
Change History (16)
This ticket was mentioned in PR #2270 on WordPress/wordpress-develop by rolf-yoast.
3 years ago
#3
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/54977
#4
@
3 years ago
I've made a patch that will add a clear: both to the Welcome Panel. But it will also add some margin to the bottom of the #screen-meta-links on the dashboard page.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
#9
@
3 years ago
- Keywords has-screenshots commit added; needs-testing removed
- Owner set to audrasjb
- Status changed from new to assigned
Self assigning for commit, since this one was successfully tested (see comments above).
3 years ago
#11
Committed in https://core.trac.wordpress.org/changeset/52735
That can happen if the "Dashboard" heading is hidden or moved below the welcome banner.
Clearing floats might keep the banner full width, but then the Screen Options and Help buttons touch the banner. The buttons may need a bottom margin, too.