Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54977 closed defect (bug) (fixed)

Dashboard welcome banner: fix bug when displayed in certain contexts

Reported by: critterverse's profile critterverse Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version: 5.9
Component: Administration Keywords: has-patch has-testing-info has-screenshots commit fixed-major
Focuses: css, administration Cc:

Description

Hi all, I'm reporting a bug that was noticed on the Dashboard where the welcome banner appears to only take up the left side of the screen (rather than the full width of the screen). In this case, the banner is appearing completely to the right of the "Screen options" and "Help" tabs in the upper right corner but those tabs should actually sit above the banner.

This bug was found in Safari and it appears that it could be a conflict with other banners that get added to this area (from jurassic.ninja, Jetpack, etc). But the misaligned visual effect remains even after other banners are closed.

Attachments (3)

dashboard-banner-bug.png (309.3 KB) - added by critterverse 2 years ago.
Capture d’écran 2022-02-04 à 11.49.31.png (823.2 KB) - added by audrasjb 2 years ago.
Before applying PR #2270
Capture d’écran 2022-02-04 à 11.49.08.png (750.0 KB) - added by audrasjb 2 years ago.
After applying PR #2270

Download all attachments as: .zip

Change History (16)

#1 @sabernhardt
2 years ago

  • Focuses css administration added

That can happen if the "Dashboard" heading is hidden or moved below the welcome banner.

Clearing floats might keep the banner full width, but then the Screen Options and Help buttons touch the banner. The buttons may need a bottom margin, too.

Last edited 2 years ago by sabernhardt (previous) (diff)

#2 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to 5.9.1

This ticket was mentioned in PR #2270 on WordPress/wordpress-develop by rolf-yoast.


2 years ago
#3

  • Keywords has-patch added; needs-patch removed

#4 @rolfsiebers
2 years ago

I've made a patch that will add a clear: both to the Welcome Panel. But it will also add some margin to the bottom of the #screen-meta-links on the dashboard page.

#5 @audrasjb
2 years ago

Thanks @rolfsiebers the patch actually fixes the underlined issue on my side 👍

#6 @SergeyBiryukov
2 years ago

  • Component changed from General to Administration

#7 @Boniu91
2 years ago

  • Keywords needs-testing has-testing-info added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

#9 @audrasjb
2 years ago

  • Keywords has-screenshots commit added; needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to assigned

Self assigning for commit, since this one was successfully tested (see comments above).

#10 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52735:

Administration: Fix a CSS issue on the Welcome Panel when the "Dashboard" heading is missing.

This change adds a CSS exception for when the "Dashboard" heading is missing or located below the Welcome Panel.

Props critterverse, sabernhardt, rolfsiebers, audrasjb.
Fixes #54977.

#12 @audrasjb
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport

#13 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52736:

Administration: Fix a CSS issue on the Welcome Panel when the "Dashboard" heading is missing.

This change adds a CSS exception for when the "Dashboard" heading is missing or located below the Welcome Panel.

Props critterverse, sabernhardt, rolfsiebers, audrasjb.
Merges [52735] to the 5.9 branch.
Fixes #54977.

Note: See TracTickets for help on using tickets.