WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #54987, comment 10


Ignore:
Timestamp:
03/13/2022 04:19:50 AM (3 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #54987, comment 10

    initial v1  
    22
    33* [attachment:54987.patch] introduces a duplicate check instead of moving the existing one.
    4 * [attachment:54987.2.patch] moves the existing check, but no longer throws a WP_Error if the nicename is too long.
    5 * [attachment:54987.diff] has some formatting changes and renames a variable, which does not seem necessary here. It also adds validation for `$user_url`, but it was already added in [52650] / #44107.
    6 * [https://github.com/WordPress/wordpress-develop/pull/2244 PR #2244] introduces a new check that `user_nicename` cannot be empty. I think this would be better discussed in a separate ticket.
     4* [attachment:54987.2.patch] moves the existing check, but no longer throws a `WP_Error` if the nicename is too long.
     5* [attachment:54987.diff] has some formatting changes and renames a variable, which does not seem necessary here. It also adds validation for `$user_url`, but that was already added in [52650] / #44107.
     6* [https://github.com/WordPress/wordpress-develop/pull/2244 PR #2244] introduces a new check that `$user_nicename` cannot be empty. I think this would be better discussed in a separate ticket.
    77
    88For this ticket, I was thinking of just moving the existing check after the filter, like in [attachment:"54987.2.diff"].