Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#55006 closed defect (bug) (fixed)

Twenty Fifteen: Button border issue

Reported by: umesh84's profile umesh84 Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: ui, css Cc:

Description

Twenty Fifteen Themes Gutenberg editor button border bottom is not working.

Attachments (6)

Screenshot_4.png (58.7 KB) - added by umesh84 2 years ago.
55006.patch (578 bytes) - added by umesh84 2 years ago.
added patch
55006.1.patch (957 bytes) - added by sabernhardt 2 years ago.
55006.2.patch (494 bytes) - added by sabernhardt 2 years ago.
removing the editor stylesheet change
c29a0c00dacd46e63efc672c502fcbb1.gif (126.7 KB) - added by audrasjb 21 months ago.
Before patch
86ab6d9c20d52253e59d9576e218fc72.gif (46.2 KB) - added by audrasjb 21 months ago.
After patch

Download all attachments as: .zip

Change History (13)

@umesh84
2 years ago

@umesh84
2 years ago

added patch

#1 @umesh84
2 years ago

  • Keywords has-patch added; needs-patch removed

#2 @mukesh27
2 years ago

#55003 was marked as a duplicate.

#3 @SergeyBiryukov
2 years ago

  • Component changed from General to Bundled Theme
  • Summary changed from Twenty Fifteen Themes button border issue to Twenty Fifteen: Button border issue

@sabernhardt
2 years ago

#4 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to 6.1

This is related to the :where() selector, which also affected Twenty Twenty (#55824).

Additional change in editor-blocks.css:
As a follow-up to r44381, 55006.1.patch also corrects .is-style-outline .wp-block-button__link:not(.has-text-color), to match blocks.css.

@sabernhardt
2 years ago

removing the editor stylesheet change

#5 @sabernhardt
2 years ago

I removed the extra edit. I had noticed a problem with Gutenberg activated, but the plugin may have fixed that already with inline styles. (And if it's not fixed, we can revisit that later for other themes, too.)

#6 @audrasjb
21 months ago

  • Keywords has-screenshots commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

I tested the patch and it looks good to me (see above screenshots).

Self-assigning for commit.

#7 @audrasjb
21 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 54151:

Twenty Fifteen: Ensure border-bottom styles are applied to the Button Block.

This issue was related to the :where() selector, which also affected Twenty Twenty (see #55824).

Props umesh84, sabernhardt.
Fixes #55006.
See #55824.

Note: See TracTickets for help on using tickets.