Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #55121, comment 5


Ignore:
Timestamp:
02/09/2022 11:05:14 AM (22 months ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #55121, comment 5

    v2 v3  
    33However, given that this has come up again, I think we should consider one of the following ways forward:
    44
    5 - If it definitely is doing it wrong and BC doesn't need to be considered, consider adding `_doing_it_wrong` to highlight this to extenders.
     5- If it definitely is doing it wrong and BC doesn't need to be taken into account, consider adding `_doing_it_wrong` to highlight this to extenders.
    66 - This lets site owners and extenders know upon updating what the issue is and how to resolve it.
    77 - `_doing_it_wrong()` is used in several areas of Core even though the documentation already states the expected type(s).
     8 - It may be worth making a retrospective update to the [https://make.wordpress.org/core/2022/01/04/miscellaneous-core-changes-in-wordpress-5-9/ 5.9 Misc dev note] and/or the [https://make.wordpress.org/core/2022/01/10/wordpress-5-9-and-php-8-0-8-1/ 5.9 PHP 8.0/8.1 dev note].
    89- If it isn't doing it wrong, consider the PR on this ticket.
    910 - ''Side note:'' The PR doesn't cover `null` values on `ArrayObject`/`ArrayIterator`, this may need to be added.