Make WordPress Core

Opened 16 years ago

Closed 16 years ago

Last modified 2 years ago

#5514 closed defect (bug) (fixed)

Non localized stringswp-admin/includes/template.php

Reported by: ranyanivhartstein's profile RanYanivHartstein Owned by: ryan's profile ryan
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.1
Component: I18N Keywords: has-patch tested
Focuses: Cc:


At line 573, the string "@" for timestamps (Meaning "At", i.e. for e.g. "At 05:00 AM") is not localized, although it is not universal. The string should be gettexted so it can be translated to the relevant usage for every language

I enclosed a patch, tested with 2.3.1

Attachments (1)

template.php.r6475.diff (1.1 KB) - added by RanYanivHartstein 16 years ago.
Patch to make "@" (in timestamps) localizable

Download all attachments as: .zip

Change History (9)

16 years ago

Patch to make "@" (in timestamps) localizable

#1 @lloydbudd
16 years ago

  • Milestone set to 2.4
  • Version set to 2.3.1

#2 @ryan
16 years ago

  • Owner changed from anonymous to ryan

How about:

%1$s%2$s%3$s @ %4$s : %5$s

This way the whole thing can be changed around.

We might be changing to a different date picker for 2.4, however, so I'm going to hold off on this for now.

#3 @RanYanivHartstein
16 years ago

That sounds great Ryan

Any news on this for 2.5?

#4 @ryan
16 years ago

We still haven't finished off the new date stuff. I'll fix it one way or the other.

#5 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6989]) Allow full localization of edit timestamp fields. fixes #5514

This ticket was mentioned in PR #2304 on WordPress/wordpress-develop by mikachan.

2 years ago

This fixes a small bug in the Twenty Seventeen theme, where transparent linked images were showing a bottom border incorrectly (via a box-shadow).

This has previously been fixed over in the themes repo, so this PR replicates the fix in Core.

Original themes issue:

Trac ticket:

Note: See TracTickets for help on using tickets.