#5514 closed defect (bug) (fixed)
Non localized stringswp-admin/includes/template.php
Reported by: | RanYanivHartstein | Owned by: | ryan |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | 2.3.1 |
Component: | I18N | Keywords: | has-patch tested |
Focuses: | Cc: |
Description
At line 573, the string "@" for timestamps (Meaning "At", i.e. for e.g. "At 05:00 AM") is not localized, although it is not universal. The string should be gettexted so it can be translated to the relevant usage for every language
I enclosed a patch, tested with 2.3.1
Attachments (1)
Change History (9)
#2
@
17 years ago
- Owner changed from anonymous to ryan
How about:
%1$s%2$s%3$s @ %4$s : %5$s
This way the whole thing can be changed around.
We might be changing to a different date picker for 2.4, however, so I'm going to hold off on this for now.
#4
@
17 years ago
We still haven't finished off the new date stuff. I'll fix it one way or the other.
This ticket was mentioned in PR #2304 on WordPress/wordpress-develop by mikachan.
3 years ago
#6
This fixes a small bug in the Twenty Seventeen theme, where transparent linked images were showing a bottom border incorrectly (via a box-shadow).
This has previously been fixed over in the themes repo, so this PR replicates the fix in Core.
Original themes issue: https://github.com/Automattic/themes/issues/5018
Trac ticket: https://core.trac.wordpress.org/ticket/5514
SergeyBiryukov commented on PR #2304:
3 years ago
#7
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/52740.
SergeyBiryukov commented on PR #2304:
3 years ago
#8
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/52740.
Patch to make "@" (in timestamps) localizable