WordPress.org

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#5515 closed defect (bug) (fixed)

Ambiguous string clashes when localizing in wp-admin/export.php l

Reported by: RanYanivHartstein Owned by: westi
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.3.2
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

When localizing to certain languages, the string "All" in the authors list in wp-admin/export.php (which means "All authors") clashes with other usages of "All".

In English, "All" can be used for "Everyone" as well as "Everything" - for e.g., in WordPress, it can be used for "All categories" as well as "All authors".

In other languages, such as Hebrew, the two are separate, and using the same term for localizing causes a clash.

I enclosed a patch that changes the string to "All authors" in wp-admin/export.php to avoid the clash.

Attachments (1)

export.php.r6475.diff (520 bytes) - added by RanYanivHartstein 14 years ago.
Patch to avoid clashin string in wp-admin/export.php

Download all attachments as: .zip

Change History (9)

@RanYanivHartstein
14 years ago

Patch to avoid clashin string in wp-admin/export.php

#1 @lloydbudd
14 years ago

  • Milestone set to 2.4
  • Version set to 2.3.2

#2 @westi
14 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Currently we have 'All' in three places in trunk:

./wp-admin/export.php:<option value="all" selected="selected"><?php _e('All'); ?></option>
./wp-admin/edit.php:            <?php wp_dropdown_categories('show_option_all='.__('All').'&hide_empty=1&hierarchical=1&show_count=1&selected='.$cat);?>
./wp-admin/link-manager.php:$select_cat .= '<option value="all"'  . (($cat_id == 'all') ? " selected='selected'" : '') . '>' . __('All') . "</option>\n";

And we need to something consistent for all of them.

Maybe we should continue using All but give them context?

#3 @RanYanivHartstein
14 years ago

I can say that for Hebrew, these are all identical and are translated the same.

However, I'm guessing other languages will have other problems, and it would be best to make sure strings are not repeated in different contexts.

Ideally, we should add comments or specific context in the string itself.

For e.g. in link-manager.php:

__('All categories')

or

_c('All|categories')

#4 follow-up: @westi
14 years ago

I think in the contexts that they are currently used with the surronding text or label detailing that it is all categories or all ... I would prefer if we switched to the the strings with context.

#5 in reply to: ↑ 4 @RanYanivHartstein
14 years ago

Replying to westi:

I think in the contexts that they are currently used with the surronding text or label detailing that it is all categories or all ... I would prefer if we switched to the the strings with context.

This is more of a UI issue. Either way (literally specifying the contexts/using hidden comments) should be good enough as far as l10n is concerned.

#6 @RanYanivHartstein
14 years ago

Any news on this for 2.5?

#7 @ryan
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6836]) Change strong to avoid gettext ambiguity. Props RanYanivHartstein. fixes #5515

#8 @ryan
14 years ago

Went with your patch since the more specific text seems better. We can address the larger issue of context in a different ticket.

Note: See TracTickets for help on using tickets.