![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 4 years ago
Closed 4 years ago
#55178 closed defect (bug) (fixed)
Allow fully extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes
| Reported by: | Mamaduka | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.9.1 |
| Component: | Themes | Version: | |
| Severity: | normal | Keywords: | has-patch dev-feedback fixed-major |
| Cc: | Focuses: |
Description
Allow fully extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes.
This requires changing method visibility from private to protected and using late static binding.
Original PRs from Gutenberg repo:
Change History (8)
This ticket was mentioned in PR #2325 on WordPress/wordpress-develop by kapilpaul.
4 years ago
#2
- Keywords has-patch added
#3
@
4 years ago
- Keywords dev-feedback added
@Mamaduka https://github.com/WordPress/wordpress-develop/pull/2322 is the correct PR for this ticket, right?
@kapilpaul proposed another PR in the ticket but it looks like e2e tests are failing.
It also includes more that what is in your PR
#4
@
4 years ago
@audrasjb, that's correct. My PR is mostly code backported from the Gutenberg plugin.
#5
@
4 years ago
@audrasjb my PR is failing e2e test. As there is another PR which is all good, I am closing my PR then.
trac-55178 fix: Allow fully extending WP_Theme_JSON and WP_Theme_JSON Resolver classes
Trac ticket: https://core.trac.wordpress.org/ticket/55178