Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55178 closed defect (bug) (fixed)

Allow fully extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes

Reported by: mamaduka's profile Mamaduka Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch dev-feedback fixed-major
Focuses: Cc:

Description

Allow fully extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes.

This requires changing method visibility from private to protected and using late static binding.

Original PRs from Gutenberg repo:

Change History (8)

#1 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 5.9.1
  • Owner set to audrasjb
  • Status changed from new to assigned

This ticket was mentioned in PR #2325 on WordPress/wordpress-develop by kapilpaul.


2 years ago
#2

  • Keywords has-patch added

trac-55178 fix: Allow fully extending WP_Theme_JSON and WP_Theme_JSON Resolver classes

Trac ticket: https://core.trac.wordpress.org/ticket/55178

#3 @audrasjb
2 years ago

  • Keywords dev-feedback added

@Mamaduka https://github.com/WordPress/wordpress-develop/pull/2322 is the correct PR for this ticket, right?
@kapilpaul proposed another PR in the ticket but it looks like e2e tests are failing.
It also includes more that what is in your PR

#4 @Mamaduka
2 years ago

@audrasjb, that's correct. My PR is mostly code backported from the Gutenberg plugin.

#5 @kapilpaul
2 years ago

@audrasjb my PR is failing e2e test. As there is another PR which is all good, I am closing my PR then.

#6 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52744:

Themes: Allow extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes.

This change updates methods visibility from private to protected and adds late static binding.

Original PRs from Gutenberg repository:

Props oandregal, Mamaduka, kapilpaul.
Fixes #55178.
See #55179.

#7 @audrasjb
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration

#8 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52746:

Themes: Allow extending WP_Theme_JSON and WP_Theme_JSON_Resolver classes.

This change updates methods visibility from private to protected and adds late static binding.

Original PRs from Gutenberg repository:

Props oandregal, Mamaduka, kapilpaul.
Merges [52744] to the 5.9 branch.
Fixes #55178.
See #55179.

Note: See TracTickets for help on using tickets.