Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55182 closed defect (bug) (fixed)

Reconsider wp_enqueue_block_style() location

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.9.1
Component: Editor Keywords: has-patch commit assigned-for-commit
Focuses: Cc:

Description

Background: #55148.

As a result of [52741] and [52743]:

  • wp_enqueue_block_support_styles() was moved to wp-includes/script-loader.php.
  • However, wp_enqueue_block_style() is still defined in wp-includes/blocks.php.

Should they both be defined in the same file for consistency?

Attachments (1)

55182.patch (7.1 KB) - added by mukesh27 2 years ago.
Initial patch.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.0

@mukesh27
2 years ago

Initial patch.

#2 @mukesh27
2 years ago

  • Keywords has-patch added

#3 @costdev
2 years ago

  • Version set to 5.9.1

#5 @audrasjb
2 years ago

  • Keywords commit assigned-for-commit added
  • Owner set to audrasjb
  • Status changed from new to assigned

In the above PR I refreshed the patch against trunk.
It looks good to go. Self assigning for commit.

#6 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53234:

Editor: Move wp_enqueue_block_style() to wp-includes/script-loader.php, for better consistency.

As a result of [52741] and [52743], wp_enqueue_block_support_styles() was moved to wp-includes/script-loader.php. However, wp_enqueue_block_style() was still defined in wp-includes/blocks.php. This changeset also moves wp_enqueue_block_support_styles() to wp-includes/script-loader.php for better consistency.

Follow-up to [52741], [52743].

Props SergeyBiryukov, mukesh27, audrasjb.
Fixes #55182.
See #55148.

Note: See TracTickets for help on using tickets.