Make WordPress Core

Opened 2 years ago

Last modified 2 months ago

#55183 new defect (bug)

Twenty Thirteen: Table color not reflect on the frontpage

Reported by: umesh84's profile umesh84 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.4
Component: Bundled Theme Keywords: has-patch dev-feedback
Focuses: ui, css Cc:

Description (last modified by sabernhardt)

Steps:

  1. Switch theme to Twenty Thirteen
  2. Create Table and change color after update
  3. Check the frontpage

Add the video Link below:
https://www.loom.com/share/6ce4c74eb3314d7bb593b0e7173e637b

Attachments (2)

55183.diff (963 bytes) - added by sabernhardt 2 years ago.
Twenty Thirteen editor style changes: class name, padding, focus outline
55183.2.diff (963 bytes) - added by sabernhardt 2 years ago.
Twenty Thirteen editor style changes: class name, padding, focus outline

Download all attachments as: .zip

Change History (8)

#1 @sabernhardt
2 years ago

  • Component changed from General to Bundled Theme
  • Focuses ui removed

#2 @nidhidhandhukiya
2 years ago

hello @sabernhardt, @umesh84
I observed that this issue is in all the themes below twenty twenty two because in the twenty twenty two we have a option available for a border and not in other themes so if we want to solved these issue we have to add the border option in other themes as well.

@sabernhardt
2 years ago

Twenty Thirteen editor style changes: class name, padding, focus outline

@sabernhardt
2 years ago

Twenty Thirteen editor style changes: class name, padding, focus outline

#3 @sabernhardt
2 years ago

  • Description modified (diff)
  • Focuses ui added
  • Keywords has-patch added; needs-patch removed
  • Version changed from 5.9 to 5.4

The problem is in the editor. Twenty Thirteen had removed the table cell border, but the editor replaced class names such as .editor-block-list__block. Now the table border inherits the text color.

Changes proposed in 55183.diff:

  • Use .block-editor-block-list__block class for table styles, while maintaining the old class name for older versions.
  • Set the cell padding to 0.5em to match the (editor) theme.css on the front end.
  • For consideration, I added a focus outline like the editor once had used on an .is-selected class. Otherwise, table content can be more difficult to edit with a very light border at the top and bottom but nothing on the left or right sides.

Similar revisions would be necessary for tables in these themes:

  • Twenty Twelve (which also does not show the text in a custom color—see #56466)
  • Twenty Fourteen
  • Twenty Seventeen
Last edited 21 months ago by sabernhardt (previous) (diff)

#4 @sabernhardt
21 months ago

r50358 replaced some instances of .editor-block-list__block with .editor-styles-wrapper, so that might be a better option.

#5 @sabernhardt
6 months ago

#58807 was marked as a duplicate.

#6 @karmatosed
2 months ago

  • Keywords dev-feedback added
Note: See TracTickets for help on using tickets.