#55190 closed defect (bug) (fixed)
Global styles duotone not rendering in post editor
Reported by: | ajlende | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9.1 | Priority: | normal |
Severity: | major | Version: | 6.0 |
Component: | Editor | Keywords: | has-patch commit fixed-major dev-reviewed |
Focuses: | Cc: |
Description
With the backported changes from [52757], duotone is not rendering in the post editor
Change History (15)
#1
@
3 years ago
- Summary changed from Duotone not rendering in post editor to Global styles duotone not rendering in post editor
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
This ticket was mentioned in PR #2331 on WordPress/wordpress-develop by ajlende.
3 years ago
#3
- Keywords has-patch added
#4
@
3 years ago
- Keywords needs-testing added; has-patch removed
- Milestone changed from Awaiting Review to 5.9.1
Hello @ajlende,
Welcome back to WordPress Core's Trac! Thanks for opening this ticket.
The Gutenberg package updates have not yet been committed. In talking with @audrasjb, as soon as he gets those committed, let's retest to see if the problem still exists.
Moving into 5.9.1 for investigation and visibility.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
#7
@
3 years ago
- Keywords has-patch commit added; needs-testing removed
I can reproduce the reported issue and confirm that PR 2331 resolves it. See the testing discussion here in slack https://wordpress.slack.com/archives/C02RQBWTW/p1645128566868619.
Marking for commit. This needs to go into 5.9 branch for 5.9.1.
#8
@
3 years ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Self-assigning for commit.
#11
@
3 years ago
- Keywords dev-feedback fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for 2nd committer review to backport [52768] to 5.9 branch.
#12
@
3 years ago
- Keywords dev-reviewed added; dev-feedback removed
Thanks @hellofromTonya, let's get this backported to 5.9 👍
hellofromtonya commented on PR #2331:
3 years ago
#14
Committed via https://core.trac.wordpress.org/changeset/52768.
#15
@
3 years ago
FYI: @ajlende noted these changes will also be ported back to the Gutenberg repo. See the discussion here in slack https://wordpress.slack.com/archives/C02RQBWTW/p1645130019747589.
Global styles duotone filters were not rendering in the post editor (there is a separate issue for the site editor (WordPress/gutenberg#37727). This fixes that by adding
wp_global_styles_render_svg_filters
to thein_admin_header
so it renders in the body before the editor.To test, use a theme which adds duotone filters to a block in theme.json (Skatepark is one such example). Or add the following to twentytwentytwo's theme.json and ensure that an image added to a post is shown with the duotone filter by default in both the editor and front end.
{{{json
{
}
}}}
Trac ticket: https://core.trac.wordpress.org/ticket/55190