WP_Comment_Query: "Column 'comment_ID' in where clause is ambiguous" when mixing 'include_unapproved' and 'meta_query'

[genosseeinhorn]

On my site, I have a custom filter for comments_template_query_args which sets $comment_args['meta_query']. This works fine except when submitting a comment that needs to be approved. The result page will use the ?unapproved= query parameter, triggering the bug.

I've created a patch which I will attach here.

[azouamauriac]

Hi there, welcome to wordpress trac, thanks for the report and patch.

Could you please provide a code(snippet) or steps to reproduce the issue?

Thanks.

https://core.trac.wordpress.org/ticket/55218

[peterwilsoncc]

Thanks for the report and patch @genosseeinhorn, I can see why that is happening.

I've created ​linked a pull request that simply contains your patch so I can get the test suite running. I suspect some tests may need to be updated to account for the change in SQL query.

[peterwilsoncc]

There were no failing tests.

I've created some that fail without the patch and now pass. They're in the linked pull request too.

[audrasjb]

The logic in the PR and unit tests looks good to me.
I added a commit to your PR to address a few docblock changes in your initial proposal :)

[peterwilsoncc]

Thanks JB.

[peterwilsoncc]

In 53291:

Comments: Avoid DB error in comment meta queries.

In WP_Comment_Query always include the table name when referencing wp_comments.comment_ID. This avoids ambiguity in when making meta queries as wp_commentmeta includes a column of the same name.

Follow up to [47887].

Props genosseeinhorn, azouamauriac, audrasjb, peterwilsoncc.
Fixes #55218.

Committed in https://core.trac.wordpress.org/changeset/53291