Attachments: add caching to wp_count_attachments

[jeherve]

I noticed that while wp_count_posts includes some caching, {{{wp_count_attachments}} does not. Would it make sense to add the same caching system there?

[jeherve]

Add caching to wp_count_attachments

[antpb]

This came up in the last media meeting and was thought to be a good candidate for 6.1

The PR refresh the patch ageist the trunk and remove function _count_attachments_cache_key function as it was called only one time in wp_count_attachments().

Trac ticket: https://core.trac.wordpress.org/ticket/55227

[mukesh27]

Hi there!

As we are nearing the release cycle of 6.1.0 let's wrap this ticket so it will merge into the core for this version. I don't find any blocker for this. @jeherve feel free to test the PR and share your feedback.

Assign to @joedolson as per last meeting. Is this ticket on your radar?

Thank you for the feedback, @costdev I have updated the code with a single apply_filters( 'wp_count_attachments' ).

Ping @antpb Media component maintainer for the review.

[mukesh27]

Hi, Added unit test for the wp_count_attachments cache

[robinwpdeveloper]

​PR #3093 looks good to me.
Thanks @mukesh27

[audrasjb]

Re-assigning for final review.

[audrasjb]

In 54255:

Media: Add caching to wp_count_attachments().

This changeset adds caching to wp_count_attachments(), for better consistency with wp_count_posts().

Props jeherve, antpb, mukesh27, robinwpdeveloper, costdev.
Fixes #55227.

Committed in https://core.trac.wordpress.org/changeset/54255

[milana_cap]

This can either go into shared Dev note of just Field guide.