Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#55230 closed defect (bug) (invalid)

Release 5.9.1 breaks administration login.

Reported by: carlduranleau's profile carlduranleau Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.9.1
Component: Login and Registration Keywords: reporter-feedback close
Focuses: administration Cc:

Description (last modified by SergeyBiryukov)

The release 5.9.1 introduced a bug in script-loader.php with this new method:

/**
 * Render the SVG filters supplied by theme.json.
 *
 * Note that this doesn't render the per-block user-defined
 * filters which are handled by wp_render_duotone_support,
 * but it should be rendered before the filtered content
 * in the body to satisfy Safari's rendering quirks.
 *
 * @since 5.9.1
 */
function wp_global_styles_render_svg_filters() {
    return;
	/*
	 * When calling via the in_admin_header action, we only want to render the
	 * SVGs on block editor pages.
	 */
	if (
		is_admin() &&
		! get_current_screen()->is_block_editor()
	) {
		return;
	}

	$filters = wp_get_global_styles_svg_filters();
	if ( ! empty( $filters ) ) {
		echo $filters;
	}
}

This method echos characters to the response stream before all "headers" and "cookies" have been pushed. This prevents the wp-login.php form to work properly because every calls to the "header" or "cookie" method then generates this warning: "Cannot modify header information – headers already sent by...”. This prevents the authentication cookie to be sent to the browser which breaks the authentication mechanism. To fix this issue, I had to add a "return;" in the new "wp_global_styles_render_svg_filters" method.

Change History (15)

#2 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Login and Registration
  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.9.2

#3 @SergeyBiryukov
3 years ago

Hi there, welcome to WordPress Trac! Thanks for the report.

Could you share the steps to reproduce the issue on a clean install?

#4 @kapilpaul
3 years ago

Could not reproduced it. Please share the reproduce steps as @SergeyBiryukov mentioned.

#5 @SergeyBiryukov
3 years ago

  • Keywords reporter-feedback added

#6 @carlduranleau
3 years ago

To reproduce this error, I only had to access the admin login page: /wp-login.php. With the DEBUG flag set, I had many warnings showing at he top of the login page. All warnings were the same: "Cannot modify header information – headers already sent by...". Even if I was able to enter my username and password, the login button was always returning me back to the same page.

Maybe I should have added my configuration in the ticket. Our website is using Corpera 1.0.2 theme with these plugins:

  • Elementor 3.1.1
  • LiteSpeed Cache 4.4.1
  • WP Google Maps 8.1.11
  • Wpazure Kit 1.1.2
  • WPForms Lite 1.6.7

#7 @audrasjb
3 years ago

  • Milestone changed from 5.9.2 to 5.9.3

Moving to milestone 5.9.3 since we're about to release 5.9.2.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

#9 follow-up: @audrasjb
3 years ago

  • Keywords needs-patch removed

Hello @carlduranleau, do you still reproduce the issue? Several people tried to reproduce it on their side using WP_DEBUG set to true, and nobody succeed.

Marking for reporter-feedback, pending steps to help reproduce the issue.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

#11 in reply to: ↑ 9 @webcommsat
3 years ago

I could not reproduce this, happy to try again when we have the steps listed too. Thanks
Replying to audrasjb:

Hello @carlduranleau, do you still reproduce the issue? Several people tried to reproduce it on their side using WP_DEBUG set to true, and nobody succeed.

Marking for reporter-feedback, pending steps to help reproduce the issue.

#12 @audrasjb
3 years ago

  • Milestone changed from 5.9.3 to 5.9.4

This issue still needs reproduction steps and WordPress 5.9.3 RC1 is scheduled tomorrow.
Moving for 5.9.4 consideration.

This ticket was mentioned in Slack in #core by mike. View the logs.


3 years ago

#14 follow-up: @peterwilsoncc
3 years ago

  • Keywords close added
  • Milestone changed from 5.9.4 to Awaiting Review
  • Severity changed from blocker to normal

This was discussed during a bug scrub earlier.

As three are no reproduction steps, it was decided to move it off the milestone and assign the close keyword. It appears there have been numerous attempts to reproduce the issue but without success.

#15 in reply to: ↑ 14 @carlduranleau
3 years ago

Replying to peterwilsoncc:

No problem, you can close the ticket. It must be a problem with the theme plugin. I had to disable automatic WP updates because the issue got back after another update.

Thank you for your help. If I find something useful, I'll let you know.

This was discussed during a bug scrub earlier.

As three are no reproduction steps, it was decided to move it off the milestone and assign the close keyword. It appears there have been numerous attempts to reproduce the issue but without success.

#16 @johnbillion
3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks for the update @carlduranleau

Note: See TracTickets for help on using tickets.