PHP Notice: Undefined variable filters in WP_Theme_JSON::get_svg_filters()

[vlad.olaru]

If a block theme completely disables the color->duotone support in theme.json, by setting it to null, a PHP notice is generated:

Notice: Undefined variable: filters in /app/public/wp-includes/class-wp-theme-json.php on line 1620

This is due to the fact that the $filters variable gets initialized in the foreach only if a node is found with a non-empty duotone entry.

Trac ticket: https://core.trac.wordpress.org/ticket/55234#ticket

[vlad.olaru]

Actually, besides the notice, the logic is also broken since $filters gets reset on each settings node with duotone.

[mukesh27]

Hi there! thanks for the ticket and patch.

#55241 ticket has a similar solution as your PR and it was already marge in the core.

Let's ping @audrasjb for 2nd review.

[audrasjb]

Hello there, thanks @vladolaru for reporting this!

Thanks for checking @mukesh27, indeed we already fixed the issue in this ticket: #55241.

Thanks for the PR @vladolaru, I'll add a mention in #55241's final commit to branch 5.9 🙂

Closing this pull request since a similar fix was already merged in core. See: https://core.trac.wordpress.org/ticket/55234#comment:4