#55238 closed defect (bug) (fixed)
Post lock data inconsistencies
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Editor | Keywords: | has-patch |
Focuses: | Cc: |
Description
There're inconsistencies between post lock data returned by the editor settings and the Heartbeat API.
- Editor settings are missing user avatar. It's fetched but never included in user details - https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/edit-form-blocks.php#L151-L157.
- Heartbeat response is missing user name. The editor expects name instead of the whole error text - https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/misc.php#L1191-L1194
I think this has been an issue since 5.0 - https://github.com/WordPress/wordpress-develop/commit/3011f8c8e76c71d842df998798bef65b3736de73.
P.S. I will follow up with PR shortly.
Change History (6)
This ticket was mentioned in PR #2508 on WordPress/wordpress-develop by Mamaduka.
3 years ago
#1
- Keywords has-patch added; needs-patch removed
3 years ago
#2
Confirm that message includes the user display name. Note: This will only work after package updates.
I'm inclined to land the changes now and re-test when we have packages updated on Friday. @Mamaduka, what do you think?
3 years ago
#3
@gziolo sounds good to me 👍 Post Lock modal design got polished so it won't look broken after the package update.
#5
@
3 years ago
- Owner set to gziolo
- Resolution set to fixed
- Status changed from new to closed
In 53070:
3 years ago
#6
Committed in https://core.trac.wordpress.org/changeset/53070.
PR is backporting fixes introduced in https://github.com/WordPress/gutenberg/pull/37914.
Changes include:
## Testing instructions
Create two admin user accounts. Save a post as one user, then log in as the other user in an incognito mode and load the same post.
Trac ticket: https://core.trac.wordpress.org/ticket/55238