Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55238 closed defect (bug) (fixed)

Post lock data inconsistencies

Reported by: mamaduka's profile Mamaduka Owned by: gziolo's profile gziolo
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

There're inconsistencies between post lock data returned by the editor settings and the Heartbeat API.

I think this has been an issue since 5.0 - https://github.com/WordPress/wordpress-develop/commit/3011f8c8e76c71d842df998798bef65b3736de73.

P.S. I will follow up with PR shortly.

Change History (6)

This ticket was mentioned in PR #2508 on WordPress/wordpress-develop by Mamaduka.


2 years ago
#1

  • Keywords has-patch added; needs-patch removed

PR is backporting fixes introduced in https://github.com/WordPress/gutenberg/pull/37914.

Changes include:

  • Add missing user avatar to block editor lock data.
  • Provide user's display name via Heartbeat API check.

## Testing instructions
Create two admin user accounts. Save a post as one user, then log in as the other user in an incognito mode and load the same post.

  • Modal should display user avatar.
  • Switch back to the initial browser window and for a heartbeat to update post lock, which might take little time.
  • Confirm that message includes the user display name. Note: This will only work after package updates.

Trac ticket: https://core.trac.wordpress.org/ticket/55238

gziolo commented on PR #2508:


2 years ago
#2

Confirm that message includes the user display name. Note: This will only work after package updates.

I'm inclined to land the changes now and re-test when we have packages updated on Friday. @Mamaduka, what do you think?

Mamaduka commented on PR #2508:


2 years ago
#3

@gziolo sounds good to me 👍 Post Lock modal design got polished so it won't look broken after the package update.

#4 @gziolo
2 years ago

  • Milestone changed from Awaiting Review to 6.0

#5 @gziolo
2 years ago

  • Owner set to gziolo
  • Resolution set to fixed
  • Status changed from new to closed

In 53070:

Editor: Fix post lock data inconsistencies

Backporting fixes introduced in WordPress/gutenberg#37914.

Props Mamaduka.
Fixes #55238.

Note: See TracTickets for help on using tickets.