![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#55300 closed task (blessed) (fixed)
tests for WP_List_Util::pluck and WP_List_Util::sort
| Reported by: | pbearne | Owned by: | hellofromTonya |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.1 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-patch has-unit-tests |
| Cc: | Focuses: |
Description
I created so test for the WP_List_Util::pluck and WP_List_Util::sort function and fixed a couple of edge cases
Change History (14)
This ticket was mentioned in PR #2371 on WordPress/wordpress-develop by pbearne.
4 years ago
#1
- Keywords has-patch has-unit-tests added
#5
@
4 years ago
- Milestone 6.0 → 6.1
- Owner set to
- Status new → assigned
With 6.0 RC1 tomorrow, moving this ticket to 6.1. It can committed when reviewed and ready.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by costdev. View the logs.
4 years ago
This ticket was mentioned in PR #3419 on WordPress/wordpress-develop by costdev.
4 years ago
#8
Trac ticket: https://core.trac.wordpress.org/ticket/55300
#9
@
4 years ago
Pinging @audrasjb and @SergeyBiryukov for review of PR 3419.
Note: Writing these tests exposed a bug in WP_List_Util::sort()/WP_List_Util::sort_callback() relating to the difference in sort order for PHP < 7 and > 7. Until this bug is fixed, or the minimum PHP version is raised to 7+, the related tests will be skipped for PHP < 7.
References:
4 years ago
#14
committed in https://core.trac.wordpress.org/changeset/54421
Fixed a couple of edge cases
Trac ticket: https://core.trac.wordpress.org/ticket/55300