Make WordPress Core

Opened 2 years ago

Closed 16 months ago

#55308 closed enhancement (maybelater)

Update WordPress version URL target

Reported by: gazthink3's profile gazthink3 Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Upgrade/Install Keywords: needs-patch
Focuses: ui, accessibility, administration Cc:

Description

It's always frustrating when the WordPress version URL opens up in the same tab; we can open the $version_url in a new tab by changing the target. It's a small change but will be helpful for some people.

Change History (11)

This ticket was mentioned in PR #2376 on WordPress/wordpress-develop by gazjones00.


2 years ago
#1

  • Keywords has-patch added

It's always frustrating when the WordPress version URL opens up in the same tab; we can open the $version_url in a new tab by changing the target. It's a small change but will be helpful for some people.

Please see - https://core.trac.wordpress.org/ticket/55308#ticket

#2 @gazthink3
2 years ago

  • Severity changed from normal to minor

joedolson commented on PR #2376:


2 years ago
#3

We've been intentionally removing instances of target=_blank from core as much as possible. While this might help some people, it will also harm some people. Adding target=blank takes choice away from the user, so for accessibility reasons we strongly recommend that it should be avoided unless in a case where opening in the same tab is likely to cause data loss.

I don't think this is one of those cases.

costdev commented on PR #2376:


2 years ago
#4

We've been intentionally removing instances of target=_blank from core as much as possible. While this might help some people, it will also harm some people. Adding target=blank takes choice away from the user, so for accessibility reasons we strongly recommend that it should be avoided unless in a case where opening in the same tab is likely to cause data loss.

I don't think this is one of those cases.

The nag can appear on all screens except the upgrade screen, but activating the link should prompt the user if there are forms with modifications, so I think you're right that this shouldn't cause any data loss.

gazjones00 commented on PR #2376:


2 years ago
#5

We've been intentionally removing instances of target=_blank from core as much as possible. While this might help some people, it will also harm some people. Adding target=blank takes choice away from the user, so for accessibility reasons we strongly recommend that it should be avoided unless in a case where opening in the same tab is likely to cause data loss.
I don't think this is one of those cases.

The nag can appear on all screens except the upgrade screen, but activating the link should prompt the user if there are forms with modifications, so I think you're right that this shouldn't cause any data loss.

Interesting, what if we were to implement something in a modal window similar to how "View details" works with plugins. I'm just trying to think of a method of implementation without disrupting the flow of things.

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


2 years ago

#7 @sabernhardt
2 years ago

  • Component changed from General to Upgrade/Install
  • Focuses administration added
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

Changing to enhancement, to consider the modal implementation (or something else other than target="_blank")

This ticket was mentioned in Slack in #accessibility by alexstine. View the logs.


2 years ago

#9 @alexstine
2 years ago

  • Keywords needs-patch added; 2nd-opinion has-patch removed

At this point, it is unlikely that the links will still open in a new tab. Added needs-patch to see if the modal solution gets movement. Discussed in Accessibility Team meeting on Slack.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


16 months ago

#11 @joedolson
16 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

We may consider adding this modal at some point in the future, so feel free to reopen if you wish to add a patch and move this forward. However, it's not a priority at the moment.

Note: See TracTickets for help on using tickets.