Counter for total plugins is not updated after a plugin is deleted

[mitogh]

Context

When a plugin is deleted, the total count is updated correctly on the left count, however, the total count is not updated correctly on the right count (as you can see on the screenshot) and by following the steps to replicate this problem.

Steps to replicate.

1. Install any plugin
2. Activate the plugin
3. Go to the plugin lists
4. Deactivate the plugin
5. Observe the total count of active plugins
6. Click on Delete and accept the prompt to remove it.
7. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted.

[costdev]

Reproc Report

Env

• Web Server: Apache (Linux)
• WordPress: 6.0-alpha-52448-src
• Browser: Chrome
• OS: Windows 10
• Theme: Twenty Twenty-Two
• Plugins: Enable Customizer

Steps to test

1. Navigate to Plugins > Installed Plugins.
2. Observe the total count of "All" plugins.
3. Click on Delete and accept the prompt to remove it.
4. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted.

Results

1. The count on the right is not updated. Issue reproduced. ✅

Milestoning for 6.0 and removing the version as this will have existed for quite some time.

[costdev]

Update item count upon plugin deletion. Do not commit this patch - it needs review for i18n.

[costdev]

Patch 55316.diff should update the item count when a plugin is deleted.

However, this does not account for i18n/rtl and will need some input from a developer familiar with this.

Steps to test:

1. Navigate to Plugins > Installed Plugins.
2. Observe the total count of "All" plugins.
3. Click on Delete and accept the prompt to remove it.
4. Observe how the total count decreased by 1 but the total items count on the right was not modified after the plugin was deleted.
5. Apply 55316.diff.
6. Run npm run build:dev.
7. Navigation to Plugins > Installed Plugins.
8. Do a hard refresh to ensure that scripts have been refreshed.
9. Repeat steps 2-4. This time, the item count should decrease by 1 as expected.

[azouamauriac]

before patch

[azouamauriac]

After patch

[azouamauriac]

After patch 'Recently Active' tab (it seems like patch does not work there )

[azouamauriac]

After patch; 'Auto-updates Disabled' tab (patch works)

[azouamauriac]

Above some test result.

[costdev]

Thanks for the tests @azouamauriac!

The patch is changing the value to plugins.all.length.

That's why it looked like the patch worked in the Auto-updates Disabled test, when in fact it was a coincedence that All and Auto-updates Disabled were the same number. I've have another look at the patch.

[costdev]

Patch updated to use the count of the current view. Still needs a refresh for i18n if anyone is familiar with this.

[costdev]

Patch updated if you have time to run more tests @azouamauriac

[swissspidy]

For proper i18n you'll need to use wp.i18n._n() together with wp.i18n.sprintf. Make sure wp-i18n is a dependency of the updates.js script if not already the case.

[costdev]

Thanks @swissspidy! I'll take a look at this now.

[azouamauriac]

after patch 55316.2.diff; same result for following tab: 'Inactive', 'Auto-updates Disabled'. The patch works

[azouamauriac]

Replying to costdev:

Patch updated if you have time to run more tests @azouamauriac

Done! Patch works on my side.

[costdev]

Thanks @azouamauriac!

I'll work on i18n and try to get this patch ready for further testing.

[costdev]

Patch updated with i18n.

[kebbet]

Perhaps use _nx() in combination with number_format_i18n() instead of just _n()? That way a comment can be added that the items word in this case means plugins, and the counter is displayed in the locales number format.

​https://developer.wordpress.org/reference/functions/_nx/
​https://developer.wordpress.org/reference/functions/number_format_i18n/

[kebbet]

Sorry, the number function can not be used with JavaScript so just ignore that part of the ”suggestion ”.

https://core.trac.wordpress.org/ticket/55316

[kebbet]

Linked PR uses _nx() in the JavaScript-file. Rest of it is ported from 55316.3.diff by @costdev.

[peterwilsoncc]

In 53124:

Plugins: Update item count when plugin deleted.

Update the item count, "N items", on the plugin list when a plugin is deleted. This matches the live updating of various other counts on the screen.

Props mitogh, costdev, azouamauriac, swissspidy, kebbet.
Fixes #55316.

Merged in https://core.trac.wordpress.org/changeset/53124