Make WordPress Core

Opened 2 years ago

Closed 21 months ago

Last modified 21 months ago

#55325 closed enhancement (fixed)

Theme Editor: Add file description for theme.json

Reported by: ocean90's profile ocean90 Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: good-first-bug has-patch commit
Focuses: administration Cc:

Description

It would be nice to show a description for theme.json in the theme editor instead of only theme.json.

The current list of file descriptions: https://core.trac.wordpress.org/browser/tags/5.9.1/src/wp-admin/includes/file.php?marks=14-65#L14

Attachments (2)

55325.png (54.3 KB) - added by ocean90 2 years ago.
File tree of Twenty Twenty-Two
55325-pr-applied.png (71.3 KB) - added by poena 21 months ago.
File list with PR applied

Download all attachments as: .zip

Change History (7)

@ocean90
2 years ago

File tree of Twenty Twenty-Two

This ticket was mentioned in PR #2425 on WordPress/wordpress-develop by kapilpaul.


2 years ago
#1

  • Keywords has-patch added; needs-patch removed

@poena
21 months ago

File list with PR applied

#2 @poena
21 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.1

The PR works well for me, thank you.

Testing instructions

Apply the PR.
Install a theme that includes a theme.json file.
In the WordPress admin area, go to Tools, Theme File Editor.
Select the theme in the drop down.
Confirm if theme.json has a description in the file list.

#3 @audrasjb
21 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

The patch looks good at a glance, thanks! Self assigning for final test and commit.

#4 @audrasjb
21 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54140:

Themes: Implement file description for theme.json.

This changeset adds a file description for theme.json. This description is notably used in the Theme File Editor.

Props ocean90, kapilpaul, poena.
Fixes #55325.

Note: See TracTickets for help on using tickets.