Make WordPress Core

Opened 4 years ago

Closed 4 weeks ago

Last modified 3 weeks ago

#55343 closed enhancement (fixed)

Add Tooltip to "Remember Me" (WP Login Form)

Reported by: generosus Owned by: rajinsharwar
Priority: normal Milestone: 7.1
Component: Login and Registration Version:
Severity: normal Keywords: dev-feedback tooltips has-patch
Cc: Focuses: ui, accessibility

Description

Currently, WordPress' login form has a checkbox labeled "Remember Me."

Over the years, there's been some debate over the verbiage used for "Remember Me" (say, versus "Stay Logged In" or "Keep Me Logged In") and what it really means.

To eliminate any confusion, this is to request the /addition of a tooltip next to "Remember Me" in the form of a question (?) mark. Further, the tooltip can offer a security warning to all users.

The content (text) for the tooltip could be:

"Selecting Remember Me reduces the number of times you’ll be asked to log in using this device. To keep your account secure, use this option only on your personal devices."

Also, in anticipation that this enhancement request will be approved, I would like to recommend updating the /affected codex page for the login form to add a code snippet that will allow developers to change the content (text) of the tooltip to suit their needs.

The above would be a nice addition or update to WordPress' login form.

Thank you.

Change History (32)

#1 @generosus
4 years ago

  • Keywords 2nd-opinion needs-docs needs-codex removed

#2 @generosus
4 years ago

Correction:

If approved, these are the affected WordPress documents:

/Code Reference Page
/Codex Page

Thank you.

#3 @generosus
4 years ago

  • Component SecurityLogin and Registration

#4 @oglekler
3 years ago

  • Focuses ui added
  • Keywords tooltips added

#5 @rajinsharwar
3 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review6.4
  • Type enhancementtask (blessed)
  • Version 5.9.1

Looking like a good improvement to the Login UI. Let's put this for 6.4

#6 @rajinsharwar
3 years ago

  • Owner set to rajinsharwar
  • Status newassigned

#7 @SergeyBiryukov
3 years ago

  • Focuses accessibility added

Similar to #55546, this would depend on implementing accessible tooltips in core, see #51006.

#8 @joedolson
3 years ago

  • Milestone 6.46.5
  • Type task (blessed)enhancement

#51006 has been moved to 6.5, so this ticket also needs to be bumped.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 years ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


3 years ago

#12 @swissspidy
2 years ago

  • Milestone 6.56.6

This ticket was mentioned in Slack in #core by oglekler. View the logs.


2 years ago

#14 @oglekler
2 years ago

  • Milestone 6.6Future Release

This ticket was discussed during bug scrub, and sadly, we have to move it to the Future releases with #51006. We will return it back when #51006 will be ready.

Add props fo @hellofromTonya and @audrasjb

This ticket was mentioned in PR #6918 on WordPress/wordpress-develop by @shub07.


2 years ago
#15

  • Keywords has-patch added; needs-patch removed
  • Add tooltip on side of Login page remember me button.
  • Can edit message of Tooltip.
  • Follow design same from ticket 51006.
  • Can be used to resolve 51006 if we make tooltip and tooltiptext by removing front selector.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


2 years ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


18 months ago

#18 @joedolson
18 months ago

  • Milestone Future Release6.8

Adding this to the milestone for a use case related to #51006.

This ticket was mentioned in Slack in #accessibility by nhrrob. View the logs.


18 months ago

#20 @joedolson
18 months ago

  • Milestone 6.86.9

Punting along with #51006.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


11 months ago

#22 @joedolson
11 months ago

  • Milestone 6.9Future Release

Punting this again. What we'd ideally like to do is implement tooltips using native CSS popovers, but we're waiting on Firefox to complete their implementation.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


4 months ago

#24 @joedolson
4 months ago

  • Milestone Future Release7.1

With CSS anchor positioning having meet the basic criteria for WordPress browser support, let's go ahead and work on a new patch to get this resolved using native tooltips.

#25 @afercia
7 weeks ago

On a general note, I would recommend to keep the usage of tooltips strictly limited to the purpose of visually exposing the accessible name of a control.

That's the pattern WordPress has adopted in the Block editor, when a control does not provide a visible label.

Start using tooltips for any sort or purpose like additional descriptions, context, and the like would introduce a pattern that isn't predictable and that would provide unexpected. I'm also pretty sure that providing tooltips for any sort of purpose will be largely abused by plugins and themes unless WordPress provides strict guidance and checks to avoid that,

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 weeks ago

#27 @wildworks
4 weeks ago

The PR automatically linked to this ticket seems to have an incorrect URL for some reason.

This is the correct PR associated with this ticket: https://github.com/WordPress/wordpress-develop/pull/12212

#28 @joedolson
4 weeks ago

  • Resolutionfixed
  • Status assignedclosed

In 62741:

Administration: Add function for tooltips and toggle tips.

Add functions wp_get_tooltip() and wp_get_toggletip() to support adding these popover interfaces in the core admin. wp_get_tooltip() is used as mechanism to expose accessible names when a control has focus or hover, and wp_get_toggletip() implements a popover disclosure dialog to provide extended help information.

Functions generate accessible markup, written to avoid excess verbosity for screen readers and apply best practices for voice command users as much as possible for icon-only controls.

Add an initial implementation of a toggle tip to explain the 'remember me' option on the login screen.

Developed in https://github.com/WordPress/wordpress-develop/pull/12212

Props joedolson, oglekler, afercia, davidbaumwald, rajinsharwar, mukesh27, swissspidy, sirlouen, rutviksavsani, wildworks, ayazahmed12, generosus, sergeybiryukov.
Fixes #51006, #55343.

This ticket was mentioned in PR #12629 on WordPress/wordpress-develop by @jeremyfelt.


3 weeks ago
#29

wp_get_toggletip() has similarly documented "optional" $args as wp_get_tooltip(). This updates the function signature to match.

Trac ticket: https://core.trac.wordpress.org/ticket/55343

#30 @jeremyfelt
3 weeks ago

@joedolson I added a quick PR to match the function signature for wp_get_toggletip() to match what I believe is the intent: an optional $args array.

@joedolson commented on PR #12629:


3 weeks ago
#31

Committed this change in https://core.trac.wordpress.org/changeset/62816, and props'ed you.

Closing this.

Note: See TracTickets for help on using tickets.