WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55355 closed defect (bug) (fixed)

Typo in wp_parse_url() description

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.0 Priority: normal
Severity: trivial Version: 4.7
Component: HTTP API Keywords: good-first-bug has-patch commit
Focuses: docs Cc:

Description

wp_parse_url() description includes this sentence:

Secondly, across various PHP versions, schemeless URLs starting containing a ":" in the query are being handled inconsistently.

"starting containing" appears to be a typo, it should probably be just "containing" instead.

Follow-up to [38726] / #36356.

Change History (9)

This ticket was mentioned in ​PR #2397 on ​WordPress/wordpress-develop by ​mehedifoysal.
3 years ago #1

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/55355

#2 @mukesh27
3 years ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to assigned

Hi there!

The patch looks fine to me and ready to marge in Core.

​mehedifoysal commented on ​PR #2397:
3 years ago #3

Hi @SergeyBiryukov, I'm working on your ticket. Can you give some feedback?

#4 @hellofromTonya
3 years ago

  • Owner changed from audrasjb to hellofromTonya
  • Status changed from assigned to reviewing

Hello @mehedi890,

Welcome back to WordPress Core Trac. Congrats on your first contribution 🌟 🎉 .

Thank you for the patching this ticket. I reviewed and approved ​PR 2397. As @mukesh27 noted, it's ready for commit.

What's the next step? I'll prepare a commit and add your change to the WordPress codebase.

#5 @mehedi890
3 years ago

Thank you @hellofromTonya

​SergeyBiryukov commented on ​PR #2397:
3 years ago #6

Thanks for the PR! This looks good to me as well, I've just pushed some minor formatting adjustments for better readability.

​hellofromtonya commented on ​PR #2397:
3 years ago #7

Thanks @SergeyBiryukov for further improvements. Prepping commit now.

#8 @hellofromTonya
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52838:

HTTP API: Fix typo in and improve readability of wp_parse_url() docblock.

Removes the "starting" word from "starting containing" as this is a typo. Includes minor formatting adjustments to improve readability.

Follow-up to [38726].

Props mehedi890, SergeyBiryukov, mukesh27.
Fixes #55355.

​hellofromtonya commented on ​PR #2397:
3 years ago #9

Committed via changeset https://core.trac.wordpress.org/changeset/52838

Thank you @mehedifoysal! Congrats on your first Core contribution 🎉

Note: See TracTickets for help on using tickets.