Passing int term term_exists parent param not respected

[spacedmonkey]

If a developer calls terms_exists, with an int as term and parent as an int, the parent value is not respected. So example this will not work.

 $term = term_exists( 123, 'category', 1);

The code will check to see if term 123 exists, but will ignore parent value. This may result in correct / unexpected results.

[lopo]

Looks more like a problem in the docs to me than an actual bug: if you give the ID as integer you don't need to restrict by parent; if you search by string, restricting by parent can definitely be helpful.

[lgadzhev]

Adding $parent to the query when $term is used as an int

[lgadzhev]

An optimized version that avoids duplicate code

[lgadzhev]

Hey, I've added a patch for that. Now it is going to include $parent in the query even when $term is int

[spacedmonkey]

@lgadzhev Thanks for your patch. Is it possible you could provide unit tests?

Fixes Ticket #55358

This PR addresses an issue in the term_exists function where the parent_term was not being respected when a term with an integer ID was passed along with a parent term ID. The function would only check if the term with the specified ID existed, ignoring the parent-child relationship.

Changes Made:

• Updated the term_exists function to include the parent parameter in the query arguments when the term is an integer and a parent term ID is specified.
• Added a condition to check for the presence of a parent term ID and include it in the query arguments.

[thehercules]

@spacedmonkey I have created a Patch ​https://github.com/WordPress/wordpress-develop/pull/6790. Could you review it and suggest changes if any.

[spacedmonkey]

@thehercules Sorry for the late reply.

Looking at your PR. How about instead of adding

if ( ! empty( $taxonomy ) && is_numeric( $parent_term ) ) {
                        $args['parent'] = (int) $parent_term;
}

into the if ( is_int( $term ) ) { statement. Move it before like this.

$defaults = apply_filters( 'term_exists_default_query_args', $defaults, $term, $taxonomy, $parent_term );

if ( ! empty( $taxonomy ) && is_numeric( $parent_term ) ) {
                        $args['parent'] = (int) $parent_term;
}

if ( is_int( $term ) ) {

that way you would not have repeated logic.

I would like to see a unit test here if possible as well. Thanks for your contribution.

[spacedmonkey]

This ticket needs unit tests.