Make WordPress Core

Opened 2 years ago

Closed 12 months ago

#55362 closed enhancement (wontfix)

Twenty Thirteen : Invalid use of display and float together in style.css file

Reported by: kajalgohel's profile kajalgohel Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-screenshots has-patch close
Focuses: css Cc:

Description

In the theme Twenty Thirteen, there is an invalid use of float and display inline-block together in the CSS style sheet.

.attachment .entry-title {
	display: inline-block;
	float: left;
	font: 300 italic 30px "Source Sans Pro", Helvetica, sans-serif;
	margin: 0;
}
.comment-reply-title small a {
	color: #131310;
	display: inline-block;
	float: right;
	height: 16px;
	overflow: hidden;
	width: 16px;
}

Attachments (4)

Screenshot 2022-03-10 at 2.22.27 PM.png (922.5 KB) - added by kajalgohel 2 years ago.
display: inline-block property is removed, and design is not breaking. display: none override the display: inline-block property
Screenshot 2022-03-10 at 2.19.47 PM.png (1.7 MB) - added by kajalgohel 2 years ago.
display: inline-block property is removed, design is not breaking.
#55362.patch (569 bytes) - added by kajalgohel 2 years ago.
display: inline-block property is removed.
#55362.2.patch (476 bytes) - added by rehanali 2 years ago.
Added patch

Change History (15)

@kajalgohel
2 years ago

display: inline-block property is removed, and design is not breaking. display: none override the display: inline-block property

@kajalgohel
2 years ago

display: inline-block property is removed, design is not breaking.

@kajalgohel
2 years ago

display: inline-block property is removed.

#1 @kajalgohel
2 years ago

  • Keywords needs-testing added

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.0

@rehanali
2 years ago

Added patch

#3 @costdev
2 years ago

  • Keywords needs-testing removed
  • Version set to 3.6

Test Report

Env

  • Web Server: Apache (Linux)
  • WordPress: 6.0-alpha-52448-src
  • Browser: Chrome
  • OS: Windows 10
  • Theme: Twenty Thirteen
  • Plugins: None activated.

Steps to test

  1. View a post on the frontend.
  2. Scroll to the comments section.
  3. Add a comment.
  4. Click "Reply" under the comment you just created. The X button should appear to the right.
  5. Apply 55362.patch.
  6. Refresh the page.
  7. Click "Reply". The X button should not have changed in any way.

Tested in responsive mode also.

Results

  1. No visible regressions.
  2. 55362.patch seems to cleanly remove the unnecessary use of inline-block and float per MDN Reference: float.

Notes

  • In related ticket #55338, @sabernhardt highlighted that the change is not necessary and linked to the same MDN reference on float.
Last edited 2 years ago by costdev (previous) (diff)

#4 @costdev
2 years ago

  • Focuses css added

Adding css focus to get feedback on whether this change should be made.

#5 @peterwilsoncc
2 years ago

Thanks for testing Colin.

It would be good to see some additional OS/Browser combinations so I'll hold off committing for now.

This ticket was mentioned in Slack in #core-css by peterwilsoncc. View the logs.


2 years ago

#7 @peterwilsoncc
2 years ago

  • Keywords close added

There's a discussion on #55338 as to whether a similar change should be made to Twenty Eleven or whether the ticket should be closed as wontfix.

It seems sensible to make the same decision for both this and the other ticket.

This ticket was mentioned in Slack in #core-themes by peterwilsoncc. View the logs.


2 years ago

#9 @costdev
2 years ago

  • Milestone changed from 6.0 to 6.1

With 6.0 Beta 1 released yesterday, I'm moving this ticket, and #55338 to the 6.1 milestone pending further discussion on whether this change is desired.

#10 @sabernhardt
21 months ago

  • Milestone changed from 6.1 to Future Release

With 6.1 Beta 1 next week, I'll move #55338 and #55362 to Future Release for a decision.

#11 @sabernhardt
12 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The proposal to retire old themes is not finalized yet, but I'll count that as the decision to close these two minor enhancement tickets.

Note: See TracTickets for help on using tickets.