Twenty Thirteen : Invalid use of display and float together in style.css file

[kajalgohel]

In the theme Twenty Thirteen, there is an invalid use of float and display inline-block together in the CSS style sheet.

.attachment .entry-title {
	display: inline-block;
	float: left;
	font: 300 italic 30px "Source Sans Pro", Helvetica, sans-serif;
	margin: 0;
}

.comment-reply-title small a {
	color: #131310;
	display: inline-block;
	float: right;
	height: 16px;
	overflow: hidden;
	width: 16px;
}

[kajalgohel]

display: inline-block property is removed, and design is not breaking. display: none override the display: inline-block property

[kajalgohel]

display: inline-block property is removed, design is not breaking.

[kajalgohel]

display: inline-block property is removed.

[rehanali]

Added patch

[costdev]

Test Report

Env

• Web Server: Apache (Linux)
• WordPress: 6.0-alpha-52448-src
• Browser: Chrome
• OS: Windows 10
• Theme: Twenty Thirteen
• Plugins: None activated.

Steps to test

1. View a post on the frontend.
2. Scroll to the comments section.
3. Add a comment.
4. Click "Reply" under the comment you just created. The X button should appear to the right.
5. Apply 55362.patch.
6. Refresh the page.
7. Click "Reply". The X button should not have changed in any way.

Tested in responsive mode also.

Results

1. No visible regressions.
2. 55362.patch seems to cleanly remove the unnecessary use of inline-block and float per ​MDN Reference: float.

Notes

• In related ticket #55338, @sabernhardt highlighted that the change is not necessary and linked to the same MDN reference on float.

[costdev]

Adding css focus to get feedback on whether this change should be made.

[peterwilsoncc]

Thanks for testing Colin.

It would be good to see some additional OS/Browser combinations so I'll hold off committing for now.

[peterwilsoncc]

There's a discussion on #55338 as to whether a similar change should be made to Twenty Eleven or whether the ticket should be closed as wontfix.

It seems sensible to make the same decision for both this and the other ticket.

[costdev]

With 6.0 Beta 1 released yesterday, I'm moving this ticket, and #55338 to the 6.1 milestone pending further discussion on whether this change is desired.

[sabernhardt]

With 6.1 Beta 1 next week, I'll move #55338 and #55362 to Future Release for a decision.

[sabernhardt]

The ​proposal to retire old themes is not finalized yet, but I'll count that as the decision to close these two minor enhancement tickets.