Requests to the media/edit endpoint are returning a 500 status

[talldanwp]

The Gutenberg e2e tests seem to have caught a bug with the media/edit endpoint.

The endpoint is now returning a 500 status for most use cases.

Creating a ticket here as I was able to ascertain that it works on a past commit of wordpress-develop, but is broken on the latest commit, so it's not a Gutenberg bug.

To reproduce:

1. Open the browser dev tools to the network tab
2. In the post editor, add an image block and upload an image
3. Select ‘Crop’ from the toolbar and adjust the zoom on the image
4. Click ‘Apply’
5. Observe that the request to the media endpoint returns a 500 status

[talldanwp]

From what I can tell, the bug was introduced with this commit - ​https://github.com/WordPress/wordpress-develop/commit/7fc225aa87c80680df01a0a82e6bb94b7773a34c.

Trac ticket: https://core.trac.wordpress.org/ticket/55367

[spacedmonkey]

Worked out the issue. Was getting a function does not exist message. Moving the function to functions.php seems to do the trick. Also makes sense to live there, this function is useful everywhere.

[costdev]

Test Report

Env

• Web Server: Apache (Linux)
• WordPress: 6.0-alpha-52448-src
• Browser: Chrome
• OS: Windows 10
• Theme: Twenty Twenty-Two
• Plugins: None activated.

Steps to test

1. Open the browser dev tools to the Network tab.
2. In the post editor, add an image block and upload an image.
3. Select Crop from the toolbar and adjust the zoom on the image.
4. Click Apply.
5. Observe that the request to the media endpoint returns a 500 status.
6. Apply ​PR 2400
7. Observe that the request to the media endpoint no longer returns a 500 status.

Results

1. Before ​PR 2400: Received a 500 status.
2. After ​PR 2400: Did not receive a 500 status.

PR resolves the issue. 👍

[costdev]

Before / After PR 2400

[antonvlasenko]

Test Report

Web Server: Apache
WordPress: 6.0-alpha
Browser: Chrome 99
OS: macOS 12.2.1
Theme: Twenty Twenty-Two
Plugins: None.

Steps to test:

1. Open the browser dev tools to the network tab.
2. In the post editor, add an image block and upload an image.
3. Select ‘Crop’ from the toolbar and adjust the zoom on the image.
4. Click ‘Apply’.
5. Observe that the request to the media endpoint returns a 500 status code.
6. Apply ​2400
7. Repeat steps 1-4.
8. Observe that the request ended successfully (200 status code).

Before:

After:

The proposed ​PR fixes the issue and therefore it should be merged.

[costdev]

Thanks for adding your test report @antonvlasenko!

Marking for commit consideration.

[hellofromTonya]

Thank you @costdev @antonvlasenko for testing and test reports. Thank you @spacedmonkey for the PR.

Assigning to me for commit.

[hellofromTonya]

In 52932:

Media: Relocate wp_filesize() function for use in frontend and backend.

A new function wp_filesize() was added with [52837]. The function lived in the wp-admin/includes/file.php file. However, this admin specific function is not loaded into memory when hitting media/edit endpoint. The result was a 500 Internal Server Error. Why? The function is invoked with that endpoint, but the function does not exist in memory.

This commit relocates the new function to the wp-includes/functions.php file. In doing so, the function is available for both the frontend and backend.

Follow-up to [52837].

Props talldanwp, spacedmonkey, costdev, antonvlasenko.
Fixes #55367.

Committed via changeset https://core.trac.wordpress.org/changeset/52932.