Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55373 closed enhancement (fixed)

Attachment template: Rename from "Media" to "Attachment"

Reported by: scruffian's profile scruffian Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: commit needs-user-docs
Focuses: Cc:

Description

This came up in https://github.com/WordPress/gutenberg/pull/39353.

Theme Authors might find the name "Attachment" easier to understand because of how it relates to the template hierarchy.

Attachments (3)

patch.diff (1.9 KB) - added by scruffian 2 years ago.
Text change
patch.2.diff (559 bytes) - added by scruffian 2 years ago.
Remove unconnected changed
55373-before-after.jpg (21.5 KB) - added by costdev 2 years ago.
Before and after patch.2.diff

Download all attachments as: .zip

Change History (10)

@scruffian
2 years ago

Text change

@scruffian
2 years ago

Remove unconnected changed

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.0

#2 @costdev
2 years ago

  • Keywords commit added
  • Version set to 5.9

This makes sense to me.

This was the only key in the array whose value differed, and this also fits with the established "Attachment" page terminology (attachment.php, "View attachment page", linking to "Attachment Page", etc).

The description states "media items or attachments", so this doesn't deviate from the description and, in fact, simply chooses the descriptor that is more commonly used in the context of templates.

Tested the patch and it works as expected.

Unless there are objections / additional strings to update, this is a reasonable and straightforward change. Marking for commit consideration.

@costdev
2 years ago

Before and after patch.2.diff

#3 @davidbaumwald
2 years ago

  • Owner set to davidbaumwald
  • Status changed from assigned to accepted

#4 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52923:

Site Editor: Rename the default attachment template from "Media" to "Attachment".

Follow-up to [52062].

Props scruffian, costdev.
Fixes #55373.

#5 @azouamauriac
2 years ago

this one should be reported upstream, isn't?

#6 @milana_cap
2 years ago

  • Keywords needs-codex added

#7 @dd32
2 years ago

  • Keywords needs-user-docs added; needs-codex removed
Note: See TracTickets for help on using tickets.