Use wp_filesize in core

[spacedmonkey]

Introduced in [52837] as part of #49412, the wp_filesize function is a wrapper around filesize. It has some improves on this function, like casting to int and filters. The filesize function is call throughout core functions. This function may be useful in more contexts.

[spacedmonkey]

CC @flixos90

Replaced usage of filesize functions to wp_filesize in wp-admin/theme-editor.php

Trac ticket: https://core.trac.wordpress.org/ticket/55376

LGTM!

[spacedmonkey]

I would consider using this function in the following places.

​https://github.com/WordPress/wordpress-develop/blob/8697aee5f9d834c1d7135524c7f13dc3c96f4d85/src/wp-includes/rest-api/endpoints/class-wp-rest-edit-site-export-controller.php#L87

​https://github.com/WordPress/wordpress-develop/blob/2648a5f984b8abf06872151898e3a61d3458a628/src/wp-includes/ms-files.php#L45

​https://github.com/WordPress/wordpress-develop/blob/ba518c2d86e62ed63b24e9a720d42aee3ab951fb/src/wp-admin/includes/class-wp-filesystem-direct.php#L490

​https://github.com/WordPress/wordpress-develop/blob/33048b933379ae48723f617588ed8aa996ca5d14/src/wp-admin/includes/class-wp-filesystem-ssh2.php#L649

​https://github.com/WordPress/wordpress-develop/blob/ba518c2d86e62ed63b24e9a720d42aee3ab951fb/src/wp-admin/includes/ms.php#L33

​https://github.com/WordPress/wordpress-develop/blob/ecf1d6a158c70dd7f10cc42c4b26ecb0fb22bb59/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php#L1287

​https://github.com/WordPress/wordpress-develop/blob/2d707c45127d204936eef48b3c9e133b60596b33/src/wp-admin/includes/update-core.php#L1256

​https://github.com/WordPress/wordpress-develop/blob/26bb0d7479e1dd08dd982513ee6bee94f4c6f13d/src/wp-admin/includes/plugin.php#L401

​https://github.com/WordPress/wordpress-develop/blob/6adff3d989319e633cfdcdb7aff4dc906087c230/src/wp-includes/script-loader.php#L2736

​https://github.com/WordPress/wordpress-develop/blob/8db1549c0f1af05fbb919ad2eeb7f7bff5a63da9/src/wp-includes/class-wp-customize-manager.php#L6035

Thanks @Chargnn for the patch. I have added some links other places where this function can be used.

[acoulombe]

Replying to spacedmonkey:

​spacedmonkey commented on ​PR #2402:

I would consider using this function in the following places.

Thank you! Looking into this right now.

[SergeyBiryukov]

Replying to spacedmonkey:

​https://github.com/WordPress/wordpress-develop/blob/ba518c2d86e62ed63b24e9a720d42aee3ab951fb/src/wp-admin/includes/class-wp-filesystem-direct.php#L490

​https://github.com/WordPress/wordpress-develop/blob/33048b933379ae48723f617588ed8aa996ca5d14/src/wp-admin/includes/class-wp-filesystem-ssh2.php#L649

​https://github.com/WordPress/wordpress-develop/blob/2d707c45127d204936eef48b3c9e133b60596b33/src/wp-admin/includes/update-core.php#L1256

I would suggest not to use wp_filesize() in WP_Filesystem_* classes or other mission-critical parts like the update_core() function, due to backward compatibiltity concerns. See the discussion in comment:2:ticket:55688.

Using wp_filesize() in other instances seems fine at a glance.

[nihar007]

Hi,

[nihar007]

Thanks, @spacedmonkey for your advice, I followed your instruction and changed the filesize() function in the rest of the files.

[spacedmonkey]

@nihar007 This patch needs a refresh.

Trac ticket: https://core.trac.wordpress.org/ticket/55376

Fixed