i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::__construct()

[SergeyBiryukov]

There is an error message in WP_Theme::__construct():

Template is missing. Standalone themes need to have a %1$s or %2$s template file. <a href="%3$s">Child themes</a> need to have a Template header in the %4$s stylesheet.

Since the Template word here is literal and is not meant to be translated, it should be moved out of the translatable string and replaced with a placeholder, similar to index.php or style.css in the same string.

When working on a patch, please note that the translator comment above the string should be updated too.

trac-55405: i18n: Use a placeholder instead of 'Template' in a message in WP_Theme::construct()

Trac ticket: https://core.trac.wordpress.org/ticket/55405

Thanks for the PR!

It looks like I forgot to mention on the ticket that only the latest instance of Template should be replaced here, specifically in this sentence:

<a href="%3$s">Child themes</a> need to have a Template header in the %4$s stylesheet.

Other instances of the word are fine as is and do need to remain translatable.

[SergeyBiryukov]

Thanks for the refresh! It looks like 55405.diff​ is still not quite correct, as it changes the first sentence instead of the one mentioned in comment:3.

55405.2.diff​ is what I meant here :)

[SergeyBiryukov]

In 53190:

I18N: Move code out of a translatable string in WP_Theme::__construct().

Props kapilpaul, azouamauriac, SergeyBiryukov.
Fixes #55405.

Merged in https://core.trac.wordpress.org/changeset/53190.

[azouamauriac]

Replying to SergeyBiryukov:

Thanks for the refresh! It looks like 55405.diff​ is still not quite correct, as it changes the first sentence instead of the one mentioned in comment:3.

55405.2.diff​ is what I meant here :)

Ooooh, sorry for the misunderstanding... I'll catch up next time.

Thanks to handle this.