Changes between Initial Version and Version 1 of Ticket #55443, comment 118
- Timestamp:
- 08/18/2022 07:06:21 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #55443, comment 118
initial v1 36 36 > Another thing that seems to not make sense is the idea to replace images by default. Why would this be needed? Only newly uploaded images will have WEBP sub-sizes, right? Then they will be used when composing new content, right? Why would WP spend so much resources looking at places where old images are used? 37 37 38 The would be used for new content if they were the only type, but since we are keeping both, the original type (JPEG) will be used in the content by default. An additional consideration is image reg neration - if users regenerate their past images, the secondary type would be generated (WebP) and the on the fly replacement will upgrade their past content images as well.38 The would be used for new content if they were the only type, but since we are keeping both, the original type (JPEG) will be used in the content by default. An additional consideration is image regeneration - if users regenerate their past images, the secondary type would be generated (WebP) and the on the fly replacement will upgrade their past content images as well. 39 39 40 40 You bring up a good point here though, there is a potential extra load cost to replacing these images that would be worth quantifying. Worth noting that this work takes place in the context of existing per-image content processing in `wp_filter_content_tags` where we already prime caches on the attachment IDs (so the cost should be low). … … 44 44 We can investigate how much this slows down sites. As I mentioned, the meta call should return cached data and one of the very check looks for `empty( $metadata['sources'] )` - returning early in that case. 45 45 46 Also, this would still be required for new sitesunless we make "only WebP" the default output.46 Also, this would still be required for new content unless we make "only WebP" the default output. 47 47 48 48