WP_Widget_Block outputs empty container if widget has no output

[stiofansisland]

There are many widgets that for some reason or another will not output any content, this can be for many reasons, one example would be for a logged in/out user.

When you create your own widget class you have control of the widget() output function and can return an empty string to prevent any output.

The WP_Widget_Block class which is used as a sort of wrapper contains its own widget() class which prevents no output even if the block has no content.

This has left empty boxes showing for many plugins widgets on sites and breaks the backward compatibility of the widgets system.

This should be as easy fix, I will create and submit a patch soon.

[stiofansisland]

Fix

[stiofansisland]

Fix in .diff format

[mehedi890]

Hi there!

I've tested this patch and its works for me
Still, I'm adding the needs-testing label to bring a few extra eyes to this ticket to see if it solves the issue.

[welcher]

The code looks good to me. I've not had a chance to test locally though.

[stiofansisland]

If there is anything i can do to help with testing (demo sites etc) please let me know.

[peterwilsoncc]

With RC1 due in a few hours, I've moved this on to the next milestone for further follow up.

I've set the version to 5.8 as that is when block widgets were introduced.

[desrosj]

Replying to stiofansisland:

If there is anything i can do to help with testing (demo sites etc) please let me know.

Are you able to provide an example widget class that can be used to demonstrate the correct behavior and step by step instructions to reproduce the incorrect behavior? That would help with testing considerably. Thanks in advance!

[audrasjb]

As per today's bug scrub:

This patch still needs testing (and testing info/example).
As 6.1 RC1 is planned next week, let's move it to Future Release to make sure it's fully tested before moving it back to another milestone.

[stiofansisland]

I can no longer replicate this. I guess something changed.

[desrosj]

Thanks for confirming @stiofansisland!