WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55460 closed enhancement (fixed)

Improve cache key generation in WP_Comment_Query

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.0 Priority: normal
Severity: normal Version: 3.1
Component: Comments Keywords: good-first-bug has-patch has-unit-tests commit
Focuses: performance Cc:

Description

Follow on from #55352.

Improve cache key generation in WP_Comment_Query to improve likely that cache is reused. Unsetting update_comment_meta_cache and update_comment_post_cache, would improve cache keys, as this fields do not affect the cache.

Change History (6)

#1 @spacedmonkey
3 years ago

  • Summary changed from Improve comment query cache key generation to Improve cache key generation in WP_Comment_Query

This ticket was mentioned in ​PR #2572 on ​WordPress/wordpress-develop by ​uday-kokitkar.
3 years ago #2

  • Keywords has-patch has-unit-tests added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/55460

#3 @spacedmonkey
3 years ago

  • Milestone changed from Future Release to 6.0
  • Owner set to spacedmonkey
  • Status changed from new to assigned

#4 @spacedmonkey
3 years ago

  • Keywords commit added

Patch look great @uday17035 . Adding the commit keyword, in hopes of getting this patch into 6.0 release.

#5 @peterwilsoncc
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53169:

Cache API: Improve cache key generation in WP_Comment_Query.

Discard the parameters update_comment_meta_cache and update_comment_post_cache when generating the cache key as neither have an effect on the database query generated.

Props uday17035, spacedmonkey.
Fixes #55460.

Note: See TracTickets for help on using tickets.