WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55461 closed enhancement (fixed)

Improve cache key generation in WP_Network_Query

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.0 Priority: normal
Severity: normal Version: 4.6
Component: Networks and Sites Keywords: good-first-bug has-patch has-unit-tests commit
Focuses: multisite, performance Cc:

Description

Follow on from #55352.

Improve cache key generation in WP_Network_Query to improve likely that cache is reused. Unsetting update_network_cache, would improve cache keys, as this fields do not affect the cache.

Change History (8)

#1 @spacedmonkey
3 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in ​PR #2486 on ​WordPress/wordpress-develop by ​manuelRod.
3 years ago #2

  • Keywords has-patch has-unit-tests added; needs-patch removed

Improve cache key generation in WP_Network_Query unsetting update_network_cache

Trac ticket: https://core.trac.wordpress.org/ticket/55461

#3 @furi3r
3 years ago

@spacedmonkey PR ready.

This ticket was mentioned in ​Slack in #core-multisite by spacedmonkey. ​View the logs.
3 years ago

#5 @spacedmonkey
3 years ago

  • Milestone changed from Awaiting Review to 6.0
  • Owner set to spacedmonkey
  • Status changed from new to assigned

#6 @johnbillion
3 years ago

  • Keywords commit added

#7 @spacedmonkey
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53098:

Networks and Sites: Improve cache key generation in WP_Network_Query class.

Improve cache key generation in the WP_Network_Query class by removing update_network_cache element in the array used to generate the cache key. This
element does not affect that cache and by removing it, it improves the likelihood of reusing an existing cache.

Props Spacedmonkey, furi3r, johnbillion, johnjamesjacoby, flixos90.
Fixes #55461.

​spacedmonkey commented on ​PR #2486:
3 years ago #8

Committed 🎉

Note: See TracTickets for help on using tickets.