Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55474 closed task (blessed) (fixed)

Backport bugfixes from Gutenberg into Core for WP 5.9.3

Reported by: audrasjb's profile audrasjb Owned by: mamaduka's profile mamaduka
Milestone: 5.9.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

This ticket aims to track backports needed from Gutenberg to Core for WP 5.9.3.

Change History (19)

#1 @audrasjb
2 years ago

@mamaduka here is a tracking ticket for Gutenberg backports.
You can refer to this ticket in the incoming PR, and I can handle the related commit(s) :)

This ticket was mentioned in PR #2472 on WordPress/wordpress-develop by Mamaduka.


2 years ago
#2

  • Keywords has-patch has-unit-tests added

Backports changes from https://github.com/WordPress/gutenberg/pull/38891.

The package update will include the block modifications from the PR.

Trac ticket: https://core.trac.wordpress.org/ticket/55474

This ticket was mentioned in PR #2473 on WordPress/wordpress-develop by Mamaduka.


2 years ago
#3

Backports changes from https://github.com/WordPress/gutenberg/pull/39164.

Props @ndiego, @alexstine, @c4rl0sbr4v0

Trac ticket: https://core.trac.wordpress.org/ticket/55474

This ticket was mentioned in PR #2474 on WordPress/wordpress-develop by Mamaduka.


2 years ago
#4

Updated packages:

 - @wordpress/block-directory@3.0.29
 - @wordpress/block-library@6.0.28
 - @wordpress/customize-widgets@2.0.29
 - @wordpress/edit-post@5.0.29
 - @wordpress/edit-site@3.0.29
 - @wordpress/edit-widgets@3.1.24

Trac ticket: https://core.trac.wordpress.org/ticket/55474

Mamaduka commented on PR #2474:


2 years ago
#5

Do not merge this; the package-lock.json has too many changes.

Mamaduka commented on PR #2474:


2 years ago
#6

@audrasjb, it looks like the previous package update was only committed into the 5.9 branch.

I see two options here:

A) We can cherry-pick this commit into the trunk and follow the default git flow.
B) I can checkout and create PR for the 5.9 branch.

Let me know which option do you prefer.

audrasjb commented on PR #2474:


2 years ago
#7

@Mamaduka hmm I'm not 100% sure we only want to commit this to branch 5.9.
In 5.9.1 we also updated packages for trunk: https://core.trac.wordpress.org/changeset/52765

Mamaduka commented on PR #2474:


2 years ago
#8

@audrasjb correct, but we forgot to do the same for 5.9.2.

Should we go with option A?

I can also try updating packages in two steps, bump for 5.9.2 and then 5.9.3.

#9 @audrasjb
2 years ago

In 53012:

Editor: Use wp_unique_id() instead of uniqid() to generate CSS class names.

Backports changes from https://github.com/WordPress/gutenberg/pull/38891.
See https://github.com/WordPress/gutenberg/issues/38889.

Props westonruter, mamaduka.
See #55474.

#11 @audrasjb
2 years ago

In 53013:

Editor: Use wp_unique_id() instead of uniqid() to generate CSS class names.

Backports changes from https://github.com/WordPress/gutenberg/pull/38891.
See https://github.com/WordPress/gutenberg/issues/38889.

Props westonruter, mamaduka.
Merges [53012] to the 5.9 branch.
See #55474.

audrasjb commented on PR #2474:


2 years ago
#12

I pinged @jorgefilipecosta who handled packages updates for the 5.9.2 security release, just to confirm we're making the right decision :)

#13 @audrasjb
2 years ago

In 53015:

Editor: Change location of block support styles in wp_head.

Backports changes from https://github.com/WordPress/gutenberg/pull/39164.

Props ndiego, alexstine, cbravobernal, mamaduka.
See #55474.

#15 @audrasjb
2 years ago

In 53017:

Editor: Change location of block support styles in wp_head.

Backports changes from https://github.com/WordPress/gutenberg/pull/39164.

Props ndiego, alexstine, cbravobernal, mamaduka.
Merges [53015] to the 5.9 branch.
See #55474.

Mamaduka commented on PR #2474:


2 years ago
#16

After discussing the issue with @jorgefilipecosta, I went with option B.

#17 @audrasjb
2 years ago

#55163 was marked as a duplicate.

#18 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53030:

Update WordPress packages for 5.9.3.

Updated packages:

  • @wordpress/block-directory@3.0.29
  • @wordpress/block-library@6.0.28
  • @wordpress/customize-widgets@2.0.29
  • @wordpress/edit-post@5.0.29
  • @wordpress/edit-site@3.0.29
  • @wordpress/edit-widgets@3.1.24

Props mamaduka, jorgefilipecosta.
Fixes #55474.

Note: See TracTickets for help on using tickets.