WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#55496 closed defect (bug) (fixed)

Escaping function missing.

Reported by: chintan1896 Owned by: SergeyBiryukov
Priority: normal Milestone: 6.0
Component: Menus Version:
Severity: normal Keywords: has-patch
Cc: Focuses: administration

Description

Escaping function missing in /wp-admin/menu-header.php file.

Attachments (2)

55496.patch​ (513 bytes ) - added by chintan1896 5 years ago.
55496.2.patch​ (677 bytes ) - added by jigar bhanushali 5 years ago.

Download all attachments as: .zip

Change History (6)

@chintan1896
5 years ago

#1 follow-up: @mukesh27
5 years ago

  • Component General → Menus
  • Keywords needs-refresh added
  • Milestone Awaiting Review → 6.0

Hi there!

Thanks for the ticket and patch.

Can you please update the escape function for ​https://github.com/WordPress/WordPress/blob/master/wp-admin/menu-header.php#L132 from esc_attr to esc_url?

@jigar bhanushali
5 years ago

#2 in reply to: ↑ 1 @jigar bhanushali
5 years ago

@mukesh27 changes applied.

#3 @SergeyBiryukov
5 years ago

  • Keywords needs-refresh removed

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 53050:

Administration: Consistently escape icon URLs in the admin menu.

Follow-up to [9154], [26664].

Props chintan1896, jigar-bhanushali, mukesh27.
Fixes #55496.

Note: See TracTickets for help on using tickets.