Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#55508 closed defect (bug) (fixed)

Floating links in Save postbox

Reported by: sabernhardt's profile sabernhardt Owned by: joedolson's profile joedolson
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: css Cc:


When on smaller screens, links for "Uploaded by" and "Uploaded to" float to the opposite side of the text.

	.misc-pub-section > a {
		float: right;
		font-size: 16px;

Screenshot from @sumitsingh (#54811):

Attachments (2)

image-details-float-right.png (20.9 KB) - added by sabernhardt 2 years ago.
screenshot with both "Uploaded by" and "Uploaded to" links
55508.diff (388 bytes) - added by sabernhardt 2 years ago.
removing float and larger font size

Download all attachments as: .zip

Change History (8)

#1 @joedolson
2 years ago

See #54811 for related issue. Probably can solve in a single patch.

#2 @joedolson
2 years ago

  • Owner set to joedolson
  • Status changed from new to accepted

2 years ago

screenshot with both "Uploaded by" and "Uploaded to" links

2 years ago

removing float and larger font size

#3 @sabernhardt
2 years ago

  • Keywords has-patch added; needs-patch removed

Floating the links on mobile started with r26134 (25858.responsive.diff)

#4 @joedolson
2 years ago

  • Keywords commit added

This looks good. It also has a small accessibility benefit, since correlating the left side / right side lay out for users with low vision at high zoom could be a problem. I'm not sure why this was ever aligned differently from on desktop; but I don't think it is any benefit. Marking for commit.

#5 @joedolson
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53115:

Media: Align username and post title in Save postbox.

Remove the float alignment that places the "Uploaded by" username and the "Uploaded to" post title on the opposite side of the Save postbox for mobile. This matches the alignment on desktop, and makes it easier for low-vision users to track the information relationship between label and content.

Props sabernhardt.
Fixes #55508.

#6 @desrosj
2 years ago

  • Milestone changed from Awaiting Review to 6.0
Note: See TracTickets for help on using tickets.