WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#55558 closed defect (bug) (fixed)

Hide/show password on new user, missaligned

Reported by: kebbet Owned by: audrasjb
Priority: normal Milestone: 6.1
Component: Users Version: 5.2
Severity: minor Keywords: has-screenshots has-patch commit
Cc: Focuses: css

Description

On small screens the button for showing the password as an incorrect right offset.

The alignment issue stems (I guess) from edit user screen which has a cancel button in the empty space.

Attachments (2)

Capture d’écran 2022-05-17 à 00.08.24.png​ (81.1 KB ) - added by audrasjb 4 years ago.
Before patch: misalignement
Capture d’écran 2022-05-17 à 00.09.54.png​ (78.8 KB ) - added by audrasjb 4 years ago.
After patch: all good!

Download all attachments as: .zip

Change History (13)

This ticket was mentioned in ​PR #2559 on ​WordPress/wordpress-develop by ​kebbet.
4 years ago #1

  • Keywords has-patch added; needs-patch removed

The issue:
https://i0.wp.com/user-images.githubusercontent.com/11491369/162711995-bfd89d98-ec97-475a-83b4-6a22ed4abae0.png

https://core.trac.wordpress.org/ticket/55558

​kebbet commented on ​PR #2559:
4 years ago #2

With patch applied
https://i0.wp.com/user-images.githubusercontent.com/11491369/162712182-7e5600c5-c089-4944-b038-5e7fb626ded5.png

#3 @kebbet
4 years ago

  • Keywords has-screenshots added

#5 @kebbet
4 years ago

The non presence of a cancel button on New User screen might have been missed in the previous ticket.

#6 @costdev
4 years ago

  • Milestone Awaiting Review → 6.1
  • Version → 5.2

​audrasjb commented on ​PR #2559:
4 years ago #7

LGTM 👍

@audrasjb
4 years ago

Before patch: misalignement

@audrasjb
4 years ago

After patch: all good!

#8 @audrasjb
4 years ago

  • Keywords commit added

I tested the above PR and the patch looks good to me!
Marking for commit.

#9 @audrasjb
4 years ago

  • Owner set to audrasjb
  • Status new → accepted

#10 @audrasjb
4 years ago

  • Resolution → fixed
  • Status accepted → closed

In 53401:

Users: Fix misalignment of new user password toggle button on mobile.

This fixes an issue where the password hide/show button was misaligned when creating a new user on small screens.

Props kebbet.
Fixes #55558.

Note: See TracTickets for help on using tickets.