Changes between Initial Version and Version 1 of Ticket #55560
- Timestamp:
- 04/12/2022 12:32:30 AM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #55560 – Description
initial v1 3 3 As part of the changes in [52170] and [52672], a `data` property was added to the Ajax response from `wp_ajax_add_tag()` to display a success notice when adding a new term on taxonomy screens. In [53123], the notice was moved to the `supplemental->notice` property. However, `data` remained due to a failing test and potential backward compatibility concerns. 4 4 5 Given that `'data' => $message` was only added to the response five months ago in [52170], never documented anywhere, and never used for anything else, I think removing it should not affect backward compatibility. Leaving it unused and duplicated, on the other hand, might cause confusion later.5 Given that `'data' => $message` was only added to the response five months ago in [52170], was never documented anywhere, and never used for anything else, I think removing it should not affect backward compatibility. Leaving it unused and duplicated, on the other hand, might cause confusion later. 6 6 7 7 Attached is a patch from #55078 that removes the property and updates the associated unit test to pass as expected. This will need a refresh once the latest patch on #55078 is committed.