Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55564 closed defect (bug) (fixed)

Twenty Twenty-One: edit translator comment in Continue Reading text

Reported by: sabernhardt's profile sabernhardt Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: docs Cc:


In twenty_twenty_one_continue_reading_text(), the translator comment does not explain that the post title is visually hidden.

Additionally, a comment for the the_content_more_link filter mentions the excerpt instead of the content.

Attachments (2)

55564.patch (922 bytes) - added by sabernhardt 2 years ago.
editing translator comment plus content more comment
55564.diff (2.7 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (9)

2 years ago

editing translator comment plus content more comment

#1 @costdev
2 years ago

  • Keywords commit added
  • Version set to 5.6

This looks good to me, marking for commit consideration.

#2 @davidbaumwald
2 years ago

  • Owner set to davidbaumwald
  • Status changed from new to reviewing

#3 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53221:

Twenty Twenty-One: Correct translator comment in twenty_twenty_one_continue_reading_text.

This commit updates the translator comment in twenty_twenty_one_continue_reading_text to indicate that the text is visually hidden. This change also corrects the comment above the the_content_more_link filter to reference the content, not the excerpt.

Props sabernhardt, costdev.
Fixes #55564.

2 years ago

#4 @SergeyBiryukov
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

55564.diff uses the same translator comment in other files of the theme.

Should we open a ticket to make these changes for other bundled themes too?

#5 @audrasjb
2 years ago

@SergeyBiryukov yeah it would makes a lot of sense to me.
I think you can commit 55564.diff under this ticket, and it would probably be nice to open a new ticket for other bundled themes.

#6 @sabernhardt
2 years ago

The ticket for other themes is opened: #55591

#7 @davidbaumwald
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 53263:

Twenty Twenty-One: Make translator comments referencing the post title consistent.

Follow-up to [53221].

Props SergeyBiryukov.
Fixes #55564.

Note: See TracTickets for help on using tickets.