Context Navigation

← Previous Ticket
Next Ticket →

#55565 closed defect (bug) (fixed)

clipboard script does not register with a version

Reported by:	desrosj	Owned by:	desrosj
Priority:	normal	Milestone:	6.0
Component:	Script Loader	Version:
Severity:	normal	Keywords:	good-first-bug has-patch commit
Cc:		Focuses:

Description

Introduced in [45044].

Currently, the clipboard script handle that loads ClipboardJS does not specify a version when being added. It seems that this is unintentional, and specifying the current version is preferred.

Attachments (1)

55565.diff (721 bytes ) - added by elifvish 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @elifvish
4 years ago

Version of external libraries keeps changing defining it will not be suitable as every time a new version comes we have to change the version. Unless you have any solution for getting versions dynamically.

Version 0, edited 4 years ago by elifvish (next)

@elifvish
4 years ago

Attachment 55565.diff added

#2 @elifvish
4 years ago

Keywords has-patch added; needs-patch removed

#3 @desrosj
4 years ago

Keywords commit added
Milestone Awaiting Review → 6.0

#4 @desrosj
4 years ago

Component External Libraries → Script Loader

#5 @desrosj
4 years ago

Owner set to desrosj
Resolution → fixed
Status new → closed

In 53173:

Script Loader: Specify the version of the clipboard library included when registering.

For external libraries, the current version included with WordPress should be specified when registering scripts.

Props elifvish.
Fixes #55565.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#55565 closed defect (bug) (fixed)

clipboard script does not register with a version

Description

Attachments (1)

Change History (6)

#1 @elifvish 4 years ago

@elifvish 4 years ago

#2 @elifvish 4 years ago

#3 @desrosj 4 years ago

#4 @desrosj 4 years ago

#5 @desrosj 4 years ago