Opened 3 years ago
Closed 2 years ago
#55567 closed task (blessed) (fixed)
Editor: Backport bug fixes for WordPress 6.0 from Gutenberg
Reported by: | gziolo | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | 6.0 |
Component: | Editor | Keywords: | has-patch commit fixed-major dev-reviewed |
Focuses: | Cc: |
Description
This is the follow-up for #55505 where we backported all necessary changes from the Gutenberg plugin for WordPress 6.0 Beta 1. That was a big task on its own so I prefer we have another one to track only bug fixes and related WordPress packages updates.
Change History (104)
This ticket was mentioned in PR #2576 on WordPress/wordpress-develop by anton-vlasenko.
3 years ago
#1
This ticket was mentioned in PR #2542 on WordPress/wordpress-develop by oandregal.
3 years ago
#2
#3
@
3 years ago
Related Ticket
Please see https://core.trac.wordpress.org/ticket/55580 for issue related to featured image as cover block.
jorgefilipecosta commented on PR #2542:
3 years ago
#5
jorgefilipecosta commented on PR #2542:
3 years ago
#6
This ticket was mentioned in PR #2600 on WordPress/wordpress-develop by Mamaduka.
3 years ago
#7
Backports changes from https://github.com/WordPress/gutenberg/pull/40416
Adds the missing
inserter
field to the Patterns item schema.
Currently, this field is omitted from the response, and patterns that should be hidden in the inserter are visible.
Props, @ndiego, for discovering a bug and testing the fix.
Trac ticket: https://core.trac.wordpress.org/ticket/55567
This ticket was mentioned in PR #2602 on WordPress/wordpress-develop by Mamaduka.
3 years ago
#8
The editor noticed this issue while I was browsing the blocks.php
file. PHP considers variables undefined until a value is assigned (or the global
keyword is used).
The updated logic matches one used in register_block_style_handle
.
It was introduced in https://core.trac.wordpress.org/changeset/53091.
Trac ticket: https://core.trac.wordpress.org/ticket/55567
Cc @gziolo, @peterwilsoncc.
peterwilsoncc commented on PR #2602:
3 years ago
#9
@Mamaduka By "editor" are you referring to the block-editor, your code editor or something else?
3 years ago
#10
@peterwilsoncc, sorry, I should've been more clear. Intelephense in VSCode triggers the notice.
peterwilsoncc commented on PR #2602:
3 years ago
#11
Thanks boss.
No need to apologize. I was double checking I understood correctly, the block editor throwing a PHP notice would be quite important.
jorgefilipecosta commented on PR #2542:
3 years ago
#12
3 years ago
#14
Committed with https://core.trac.wordpress.org/changeset/53209.
3 years ago
#16
Committed with https://core.trac.wordpress.org/changeset/53210.
3 years ago
#17
Committed with https://core.trac.wordpress.org/changeset/53211.
3 years ago
#19
Sorry about copy-pasta, @gziolo.
Actually, it'd be perfectly fine to avoid using the text domain in the Gutenberg plugin in files that we know are meant to be moved to core 😄
This ticket was mentioned in PR #2603 on WordPress/wordpress-develop by gziolo.
3 years ago
#23
Trac ticket: https://core.trac.wordpress.org/ticket/55567
3 years ago
#25
Committed with https://core.trac.wordpress.org/changeset/53219.
This ticket was mentioned in PR #2613 on WordPress/wordpress-develop by DAreRodz.
3 years ago
#26
- Keywords has-unit-tests added
Finish the backport of the Comment blocks, adding the remaining unit tests that were not included previously. I also backported some minor changes that were made in Gutenberg.
This is a follow up of #2543
Trac ticket: https://core.trac.wordpress.org/ticket/55567
This ticket was mentioned in PR #2615 on WordPress/wordpress-develop by Mamaduka.
3 years ago
#27
Backports changes from https://github.com/WordPress/gutenberg/pull/40468.
The lock
attribute needs to be supported by every block, but currently, it is only done on the client site. As a result, it was causing block rendered API requests to fail when blocks are locked.
PR updates the WP_Block_Type
class to handle built-in/core attribute registration.
Trac ticket: https://core.trac.wordpress.org/ticket/55567
cc @gziolo, @hellofromtonya
This ticket was mentioned in PR #2622 on WordPress/wordpress-develop by hellofromtonya.
3 years ago
#29
This is a backport of the internal-only theme.json
webfonts handler https://github.com/WordPress/gutenberg/pull/40493.
Please note: This is a stopgap solution for WP 6.0. It will be replaced once the Webfonts API is ready for Core.
There's a lot of context that goes into why this implementation is being backported for 6.0 during beta. Please see full see Gutenberg's PR 40493 and its tracking issue.
The design is funky, but intentional. It's hiding all of the inner-workings to prevent backwards-compatibility breaks once the public Webfonts API is merged into Core (since that API is still in development).
Trac ticket: https://core.trac.wordpress.org/ticket/55567
cc @peterwilsoncc
peterwilsoncc commented on PR #2622:
3 years ago
#30
I've pushed six commits with the changes requests in my original review. I've since added a couple more comments regarding the test failure and ability to upload files.
I am considering whether it would be easier to:
- add the font types to
wp_get_mime_types()
directly - disallow fonts for users with filtered access in
get_allowed_mime_types()
It seems likely the fonts will be added to the former function once the API is introduced.
hellofromtonya commented on PR #2622:
3 years ago
#31
I am considering whether it would be easier to
- add the font types to
wp_get_mime_types()
directly
I thought about that too. But if the API itself is still in experimental / development, my thinking was to keep it within this stoppgap function so that it can easily be turned off with a single remove_action()
, letting the API continue on its path towards maturing as a Core API. In doing so, Gutenberg can turn off all of this stopgap code with one line of code, thus replacing it with the API.
- disallow fonts for users with filtered access in
get_allowed_mime_types()
Hey @peterwilsoncc, do you mean removing font types before they go through the 'upload_mimes'
filter? If yes, how would the API in Gutenberg modify the font types, if needed, during its continued development?
This ticket was mentioned in PR #2624 on WordPress/wordpress-develop by oandregal.
3 years ago
#32
Backports https://github.com/WordPress/gutenberg/pull/37728
Trac ticket https://core.trac.wordpress.org/ticket/55567
This fixes an issue by which link color behaves differently in the editor and front end.
Step by step reproduction instructions:
- Create a group block and set the link color to red.
- Create a paragraph block and set the link color to purple.
The expected result is that both editor and front end show the paragraph link color as purple.
This ticket was mentioned in PR #2623 on WordPress/wordpress-develop by luisherranz.
3 years ago
#33
This is a backport that exposes the default_comments_status
option in the Editor, under the discussion settings, which then is then used by the Post Comments and Post Comments Form blocks.
The Gutenberg PR where this was introduced (Post Comments block): #40484
The option is also used now in the Post Comments Form block: #40563
Trac ticket: https://core.trac.wordpress.org/ticket/55567
3 years ago
#34
Let's use the existing ticket for backports: https://core.trac.wordpress.org/ticket/55567
3 years ago
#37
Committed with https://core.trac.wordpress.org/changeset/53258.
3 years ago
#38
Committed with https://core.trac.wordpress.org/changeset/53259.
3 years ago
#40
Committed with https://core.trac.wordpress.org/changeset/53260.
3 years ago
#41
Let's plan to land this patch tomorrow. I see two remaining tasks:
CORE_ATTRIBUTES
->GLOBAL_ATTRIBUTES
- setup for attributes should happen before the
register_block_type_args
filter
3 years ago
#44
Committed with https://core.trac.wordpress.org/changeset/53268.
This ticket was mentioned in PR #2629 on WordPress/wordpress-develop by adamziel.
3 years ago
#45
## What?
This huge PR is required to ship WordPress 6.0 Beta 3. It is part of the process described in the developer handbook.
This PR was prepared using the same process as https://github.com/WordPress/wordpress-develop/pull/2564, except part of it got automated thanks to https://github.com/WordPress/wordpress-develop/pull/2621.
cc @gziolo
Trac Ticket: https://core.trac.wordpress.org/ticket/55567
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
3 years ago
#47
I tested the latest version of this PR against TT2's style variations #2440 and the fonts are loading as expected 👏 :
3 years ago
#48
Committed with https://core.trac.wordpress.org/changeset/53278.
hellofromtonya commented on PR #2622:
3 years ago
#49
Thank you @peterwilsoncc @aristath @jffng! I pushed some unhappy path integration tests. Once CI is all green 🟢 , I'll get this backport PR committed.
hellofromtonya commented on PR #2622:
3 years ago
#51
Committed via https://core.trac.wordpress.org/changeset/53282.
#52
follow-up:
↓ 54
@
3 years ago
- Keywords needs-patch added; has-patch removed
53282 introduced incorrect textdomain for l18n-strings, should be default, not 'gutenberg'
This ticket was mentioned in PR #2640 on WordPress/wordpress-develop by Mamaduka.
3 years ago
#55
- Keywords has-patch added
Backports changes from https://github.com/WordPress/gutenberg/pull/40650.
Patch fixes regression introduced in a807e86391817a45dd82f54bef234be1a28d4c6d, and moves core "Featured" pattern category registraion from _load_remote_featured_patterns
into _register_core_block_patterns_and_categories
## Testing Instructions
- Activate the 2016 theme or any theme that doesn't register Featured pattern categories.
- Open a Post or Page.
- Open Block inserter -> Patterns Tab
- Confirm that the "Featured" patterns category is registered.
Trac ticket: https://core.trac.wordpress.org/ticket/55567
cc @gziolo, @hellofromtonya
3 years ago
#57
Committed with https://core.trac.wordpress.org/changeset/53312.
This ticket was mentioned in PR #2651 on WordPress/wordpress-develop by gziolo.
3 years ago
#58
Trac ticket: https://core.trac.wordpress.org/ticket/55567
3 years ago
#60
Is there a fix planned for this issue? https://github.com/WordPress/gutenberg/issues/40675
3 years ago
#61
Is there a fix planned for this issue? WordPress/gutenberg#40675
It's listed on the board with fixes for 6.0 but there is no patch. It won't be included today.
3 years ago
#62
Committed with https://core.trac.wordpress.org/changeset/53329.
This ticket was mentioned in Slack in #core by chaion07. View the logs.
3 years ago
This ticket was mentioned in PR #2668 on WordPress/wordpress-develop by gziolo.
3 years ago
#64
Trac ticket: https://core.trac.wordpress.org/ticket/55567
hellofromtonya commented on PR #2668:
3 years ago
#66
Committed via changeset https://core.trac.wordpress.org/changeset/53338.
#67
@
3 years ago
- Resolution set to fixed
- Status changed from new to closed
As RC1 is today and all backports have been committed ahead of it, closing this ticket for now. Please reopen during the RC cycle if/when there are backports needed.
This ticket was mentioned in PR #2696 on WordPress/wordpress-develop by gziolo.
3 years ago
#69
Trac ticket: https://core.trac.wordpress.org/ticket/55567
3 years ago
#71
Committed to trunk
with https://core.trac.wordpress.org/changeset/53377.
#72
@
3 years ago
- Keywords commit dev-feedback added
Marking [53377] for backport consideration to 6.0-branch.
#73
@
3 years ago
Sorry but I think the ”“ (“ and ”) should be inside the translateable string, as the use of them differs in different locales. In sv_SE we never user “, only ”.
#74
follow-up:
↓ 80
@
3 years ago
@kebbet is referring to this line of code:
$post_title = '“' . get_the_title() . '”';
and converting it into:
/* translators: %s: Post title. */
$post_title = __( '“%s”', get_the_title() );
This change will to be done in Gutenberg as the block specific files are managed and published from there. @gziolo is there time before RC2?
This ticket was mentioned in PR #2697 on WordPress/wordpress-develop by gziolo.
3 years ago
#75
Trac ticket: https://core.trac.wordpress.org/ticket/55567
3 years ago
#76
I included a partial bug fix from https://github.com/WordPress/wordpress-develop/pull/2679 for the Gutenberg syncing script.
3 years ago
#79
Committed with https://core.trac.wordpress.org/changeset/53378.
#80
in reply to:
↑ 74
;
follow-up:
↓ 82
@
3 years ago
Replying to hellofromTonya:
and converting it into:
/* translators: %s: Post title. */ $post_title = __( '“%s”', get_the_title() );
Alternatively, two existing strings from wptexturize()
could be reused here:
/* translators: Opening curly double quote. */ $opening_quote = _x( '“', 'opening curly double quote' ); /* translators: Closing curly double quote. */ $closing_quote = _x( '”', 'closing curly double quote' );
#81
@
3 years ago
- Keywords dev-reviewed added; dev-feedback removed
[53377] and [53378] both have string changes in it. The text portion of the [53377]
strings are not changed; rather, the empty space and %s
post title placeholder are not part of the translatable string. These changes were openly discussed within the Making WordPress #polyglots channel. Looks like Polyglots are aware and there's consensus for the change 👍
Marking [53377] and [53378] ready for backport to 6.0-branch.
#82
in reply to:
↑ 80
@
3 years ago
Replying to SergeyBiryukov:
Alternatively, two existing strings from
wptexturize()
could be reused here:
/* translators: Opening curly double quote. */ $opening_quote = _x( '“', 'opening curly double quote' ); /* translators: Closing curly double quote. */ $closing_quote = _x( '”', 'closing curly double quote' );
Oh even better. That change would need to happen in the Gutenberg repository. Could be a consistency follow-up for RC3.
#83
@
3 years ago
- Owner set to hellofromTonya
- Resolution set to fixed
- Status changed from reopened to closed
In 53381:
#85
@
2 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
This ticket was mentioned in PR #2723 on WordPress/wordpress-develop by gziolo.
2 years ago
#86
Trac ticket: https://core.trac.wordpress.org/ticket/55567
2 years ago
#88
Committed with https://core.trac.wordpress.org/changeset/53403.
This ticket was mentioned in PR #2672 on WordPress/wordpress-develop by jsnajdr.
2 years ago
#90
This reverts commit 31c2639b80cf532abe2506c0a20c2ddd61ca71fc.
As a companion to Gutenberg https://github.com/WordPress/gutenberg/pull/40818, start adding __experimentaBlockPatterns
and __experimentalBlockPatternCategories
to server-generated editor settings. That makes sure that patterns registered in admin_init
or current_screen
are not lost.
Fixes https://github.com/WordPress/gutenberg/issues/40736
Trac ticket: https://core.trac.wordpress.org/ticket/55567
2 years ago
#91
Committed with https://core.trac.wordpress.org/changeset/53404.
#92
@
2 years ago
- Keywords dev-feedback added; dev-reviewed removed
This ticket was mentioned in PR #2734 on WordPress/wordpress-develop by adamziel.
2 years ago
#96
Trac ticket: https://core.trac.wordpress.org/ticket/55567
2 years ago
#98
Committed with https://core.trac.wordpress.org/changeset/53420.
#99
follow-up:
↓ 100
@
2 years ago
- Keywords dev-feedback added; dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
#100
in reply to:
↑ 99
@
2 years ago
Replying to gziolo:
Marking 2 commits [53419], [53420] for backport consideration to 6.0-branch.
[53419] looks good to backport.
In [53420], it seems like the new $fallback_gap_value
parameter of wp_get_layout_style()
is missing a description, it should be added to the function DocBlock. Otherwise, looks good too.
This PR aims to fix an issue with fetching remote patterns multiple times inside the WP_REST_Block_Patterns_Controller::get_items method.
Trac ticket: https://core.trac.wordpress.org/ticket/55567
Also, see https://github.com/WordPress/wordpress-develop/pull/2488