WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#5558 closed defect (bug) (invalid)

RDF item IDs differ from Atom/RSS item IDs

Reported by: kurtmckee Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: Feeds Keywords: has-patch needs-testing close
Focuses: Cc:

Description

After moving my Wordpress install to a new domain, I have discovered that RDF item IDs are generated using the_permalink_rss(), while Atom and RSS item IDs are generated using the_guid(). Thus, Atom and RSS items maintain their old IDs, while RDF items suddenly have brand new IDs, causing duplication in aggregators.

It appears that this can be fixed by modifying two lines in feed-rdf.php.

The original lines:
<rdf:li rdf:resource="<?php the_permalink_rss() ?>"/>
<item rdf:about="<?php the_permalink_rss() ?>">

The new lines:
<rdf:li rdf:resource="<?php the_guid() ?>"/>
<item rdf:about="<?php the_guid() ?>">

Attachments (3)

5558.diff (394 bytes) - added by lloydbudd 6 years ago.
5558.r6630.diff (774 bytes) - added by hansengel 6 years ago.
Fixes #5558 with r6630, synchronzing RDF item IDs with those of RSS and Atom feeds—corrects both ID declarations
fix-rdf-IDs.diff (739 bytes) - added by kurtmckee 4 years ago.
Replace two the_permalink_rss() calls with the_guid(). Applies to trunk (rev 13579).

Download all attachments as: .zip

Change History (13)

lloydbudd6 years ago

comment:1 kurtmckee6 years ago

I don't think that 5558.diff solves the problem completely; it leaves the second line I noted unchanged. I think that RDF's format requires that both lines be changed?

hansengel6 years ago

Fixes #5558 with r6630, synchronzing RDF item IDs with those of RSS and Atom feeds—corrects both ID declarations

comment:2 hansengel6 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from 2.6 to 2.5
  • Version set to 2.5

comment:3 kurtmckee6 years ago

I've tested the patch, and it appears to be working.

comment:4 Denis-de-Bernardy5 years ago

  • Component changed from General to Feeds
  • Owner anonymous deleted

itching to close as wontfix from lack of traction.

comment:5 Denis-de-Bernardy5 years ago

  • Keywords close added

comment:6 hakre5 years ago

let's close this, and those who want to reopen should at least test the patch then.

comment:7 hakre5 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

kurtmckee4 years ago

Replace two the_permalink_rss() calls with the_guid(). Applies to trunk (rev 13579).

comment:8 kurtmckee4 years ago

  • Cc kurtmckee added
  • Resolution wontfix deleted
  • Status changed from closed to reopened

I apologize for not responding back; I had no idea this didn't get accepted, and didn't notice until I ran into the bug again this week. The file I just attached will fix the problem, and it applies to trunk, revision 13579 (odd ascending numbers...nice).

comment:9 Denis-de-Bernardy4 years ago

  • Milestone 2.9 deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

bit too late... rdf and rss.92 have been deprecated in WP 3.0

comment:10 kurtmckee4 years ago

Okay. Thanks for the quick response!

Note: See TracTickets for help on using tickets.