Make WordPress Core

Opened 3 years ago

Closed 7 months ago

#55590 closed defect (bug) (worksforme)

Twenty Twenty-Two: Single Post Comment Form Button Font Family

Reported by: kafleg's profile kafleg Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In TT2 theme, the font of the Post Comment button of the comment form in the single post is different than others. Added a CSS code to fix that.

https://github.com/WordPress/wordpress-develop/pull/2606

Change History (5)

#1 @costdev
3 years ago

  • Version changed from trunk to 5.9

Test Report

Environment

  • Server: Apache (Linux)
  • WordPress: 6.0-beta3-53290-src
  • Browser: Chrome 100.0.4896.127
  • OS: Windows 10
  • Theme: Twenty Twenty-Two
  • Plugins: None activated.

Steps

  1. Visit a single post.
  2. Notice that the font of the "Post Comment" button is different than other fonts. ✅
  3. Apply PR 2606.
  4. Notice that the font of the "Post Comment" button is now the same as other fonts. ✅

Results

  1. Issue reproduced. ✅
  2. PR 2606 resolves the issue. ✅

#2 @costdev
3 years ago

  • Keywords has-patch added; needs-testing removed

#3 @jffng
3 years ago

Hi @kafleg thanks for the ticket and PR. Instead of CSS, could we add this via theme.json instead under styles > blocks > core/button > typography > fontFamily?

This ticket was mentioned in PR #2606 on WordPress/wordpress-develop by kafleg.


3 years ago
#4

In TT2 theme, the font of the Post Comment button of the comment form in the single post is different than others. Added a CSS code to fix that.

Trac ticket: https://core.trac.wordpress.org/ticket/55590

#5 @sabernhardt
7 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed
  • Summary changed from Twenty Twenty Two - Single Post Comment Form Button Font Family to Twenty Twenty-Two: Single Post Comment Form Button Font Family

This seems to have been fixed in Gutenberg for WordPress 6.1, possibly involving [54162].

I experienced the wrong font in WordPress 5.9 with the default (legacy) Post Comments Form block, but that submit button used inherit in 6.1 and does now in 6.5.

If I missed a way to reproduce it in recent versions, please reopen the ticket. Thanks!

Note: See TracTickets for help on using tickets.