Add 'ajax_term_search_results' filter

[grandeljay]

I want to create a plugin which suggests existing tags, if they are similar to existing tags. For this I want to hook into the term results, but it seems there is no way to. This filter should solve that.

​https://github.com/WordPress/wordpress-develop/pull/2620

https://core.trac.wordpress.org/ticket/55606

I want to create a plugin which suggests existing tags, if they are similar to existing tags. For this I want to hook into the term results, but it seems there is no way to. This filter should solve that.

[costdev]

Hi @grandeljay, welcome to Trac and thanks for the PR!

I have added some thoughts in my review.

[grandeljay]

Thanks @costdev!

I've added my replies (not sure if you get notifications for those).

I think I figured out what went wrong with the unit test. It should work now 👍🏼

[ironprogrammer]

Referenced ​PR 2620 resolved dev reviewer feedback and includes unit tests. Tagged to move forward with testing.

[audrasjb]

PR tested using the following snippet:

function append_kokomo_tags( $results, $tax, $s ) {
	$kokomo = array( 'aruba', 'bermuda', 'key largo', 'montego' );

	$results = array_merge( $results, $kokomo );

	return $results;
}
add_filter( 'wp_after_tag_search', 'append_kokomo_tags', 10, 3 );

Works fine.

[audrasjb]

works fine with the above test snippet

[SergeyBiryukov]

For consistency with the existing term_search_min_chars filter just a few lines above in the same function, I think term_search_results would be a better name for this filter. (Starting them both with ajax_term_search_*, or ajax_tag_search_* to match the function name, would perhaps have been even better, but that ship has sailed.)

Generally, it appears that core uses the *_after_* wording for actions, not for filters.

[SergeyBiryukov]

Replying to SergeyBiryukov:

For consistency with the existing term_search_min_chars filter just a few lines above in the same function, I think term_search_results would be a better name for this filter.

Thinking about this some more, that seems a bit too generic :) Maybe ajax_term_search_results? Though it does not exactly align with the existing filter, I think it might be helpful to be more specific here.

[costdev]

@SergeyBiryukov Agreed! Using ajax_term_search_results makes sense here.

[audrasjb]

Agreed! I added one commit to the existing PR.

[audrasjb]

In 53781:

Taxonomy: Allow filtering Ajax term search results in quick edit.

This changeset introduces the ajax_term_search_results hook which can be used to filter the term search results returned by the AJAX term query.

Props grandeljay, costdev, ironprogrammer, audrasjb, SergeyBiryukov.
Fixes #55606.

Committed in https://core.trac.wordpress.org/changeset/53781

[SergeyBiryukov]

Renaming the ticket to match the filter name added in [53781].