WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55619 closed defect (bug) (invalid)

Different order of params, results in a different cache key in query classes.

Reported by: spacedmonkey's profile spacedmonkey Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0
Component: Cache API Keywords: needs-patch
Focuses: performance Cc:

Description

In [52970] [53169] [53097] [53098], the cache key generation was improved. However while testing, it was noted that depending on when order in which params are sent to the query classes, this may result in a different cache to generated.

To be safe, the array used generate the cache key, should be sorted.

See ##55352, #55460, #55462, #55461.

Change History (3)

This ticket was mentioned in ​PR #2628 on ​WordPress/wordpress-develop by ​spacedmonkey.
3 years ago #1

  • Keywords has-patch has-unit-tests added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/55619

#2 @spacedmonkey
3 years ago

  • Keywords needs-patch added; has-patch has-unit-tests removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Closing as invalid.

​spacedmonkey commented on ​PR #2628:
3 years ago #3

Closing as invalid.

Note: See TracTickets for help on using tickets.