#55634 closed defect (bug) (fixed)
Editor: Update build_comment_query_vars_from_block to handle unapproved comments
Reported by: | darerodz | Owned by: | peterwilsoncc |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | 6.0 |
Component: | Editor | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
The build_comment_query_vars_from_block
function has been updated recently in Gutenberg (see https://github.com/WordPress/gutenberg/pull/40612), where we solved a problem with comment previews not being rendered.
Some PHP unit tests related to that function are failing there because that function is already defined in WordPress 6.0, so, in order to make those tests work, we have to backport first the changes in that function into WordPress, as explained in https://github.com/WordPress/gutenberg/pull/40612#issuecomment-1110107499.
Change History (8)
This ticket was mentioned in PR #2637 on WordPress/wordpress-develop by DAreRodz.
3 years ago
#1
- Keywords has-patch has-unit-tests added
3 years ago
#2
@peterwilsoncc Would you mind committing this to Core? 🙏
(It's a prerequisite for https://github.com/WordPress/gutenberg/pull/40612 and https://github.com/WordPress/gutenberg/pull/40659, which will fix https://github.com/WordPress/gutenberg/issues/40601.)
#3
@
3 years ago
- Milestone changed from Awaiting Review to 6.0
- Owner set to peterwilsoncc
- Status changed from new to accepted
#4
@
3 years ago
- Type changed from enhancement to defect (bug)
- Version set to trunk
Also marking this as a bug as it's a long term feature WP that is needed for FSE too.
Backports some changes in
build_comment_query_vars_from_block
to handle comment previews done in the Gutenberg repo. We need these changes in core before merging https://github.com/WordPress/gutenberg/pull/40612 as explained in https://github.com/WordPress/gutenberg/pull/40612#issuecomment-1110107499.Trac ticket: https://core.trac.wordpress.org/ticket/55634