WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #55635, comment 10


Ignore:
Timestamp:
04/28/2022 07:38:32 PM (3 years ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #55635, comment 10

    initial v1  
    1111Per my previous comment, I suggest that we don't sacrifice performance due to disagreement with a rule in the coding standard, and instead either meet the coding standard, or ignore the rule if consensus moves in that direction.
    1212
    13 However, IMO, all patches should meet the coding standard, and if exceptions are to be made, they should be made about a near-final patch. Otherwise we'd have a significant increase in the number of `phpcs:ignore` comments in Core. As this ticket still has a number of steps to go through, including looking at two different proposed solutions, I think we should focus on these first.
     13However, IMO, all patches should meet the coding standard, and if exceptions are to be made, they should be made about a near-final patch. Otherwise we'd have a significant increase in the number of `phpcs:ignore` comments in Core if an individual contributor added an ignore comment and reviewers just happened to miss it. As this ticket still has a number of steps to go through, including looking at two different proposed solutions, I think we should focus on these first.